fix(LoadingButton): allow submit buttons to submit their form#600
Merged
Conversation
The data-api click handler called event.preventDefault(), which stopped a button[type=submit] with data-coreui-toggle="loading-button" from submitting its form. Drop the preventDefault so the default action runs while the loading state still starts.
Coverage Report for CI Build 29294566657Coverage decreased (-0.02%) to 94.635%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data-api click handler for `data-coreui-toggle="loading-button"` called `event.preventDefault()`, so a `` inside a `` never submitted the form. Adding the loading state should not suppress the button's default action.
Fix
Remove the `event.preventDefault()` from the data-api handler. The loading state still starts on click; the default action (form submit, etc.) now runs as expected.
Tests
Parity
Vanilla-only bug — it lives in the `data-coreui-toggle` auto-init handler. The React/Vue/Angular `CLoadingButton` components do not call `preventDefault` (they just invoke the user's `onClick`), so submit works there already. No cross-framework port needed.
Closes #546. Original fix by @vladrusu.