chore: ban Array/String.prototype.at() via eslint#603
Merged
Conversation
…rties Guards against reintroducing .at(), which is unsupported in the browsers declared in .browserslistrc (Chrome < 92, Safari < 15.4) and is not polyfilled by the build.
Coverage Report for CI Build 29297832842Coverage remained the same at 94.655%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #602. Adds an eslint
no-restricted-propertiesrule that forbids.at():Array.prototype.at()/String.prototype.at()require Chrome 92 / Safari 15.4 / iOS 15.4, but.browserslistrcdeclares Chrome >= 60 / Safari >= 12 and the build does not polyfill (.babelrc.jshas nouseBuiltIns). The rule guards against silently reintroducing it.js/srcis already.at()-free, so lint is green.