fix(directives): render tooltip/popover content as text to prevent XSS#351
Merged
Conversation
v-c-tooltip and v-c-popover wrote binding content (and the popover header) straight into innerHTML with no sanitizer, so a value like <img src=x onerror=...> executed. Build the tooltip/popover structure with DOM nodes and set content via textContent, matching Bootstrap's html:false default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix —
v-c-tooltip/v-c-popoverdirective XSSBoth directives wrote the binding content (and the popover header) straight into
innerHTMLwith no sanitizer — unlike the vanilla tooltip, which sanitizes with an allow list. A value such as<img src=x onerror=…>executed.Fix
Build the tooltip/popover structure with DOM nodes and set content via
textContent, matching Bootstrap'shtml: falsedefault. All documented usage passes plain-text content, so rendering is unchanged.Regression tests added.