Fix BlockLinearOperator._getitem slicing for cross-block indices#130
Open
robrui wants to merge 1 commit intocornellius-gp:mainfrom
Open
Fix BlockLinearOperator._getitem slicing for cross-block indices#130robrui wants to merge 1 commit intocornellius-gp:mainfrom
robrui wants to merge 1 commit intocornellius-gp:mainfrom
Conversation
The modulo check used num_blocks instead of block_size, so slices aligned to individual blocks (e.g. bd[:12, :12] with block_size=12) were incorrectly handled. Also, cross-block slices (row blocks != col blocks) fell through to block-level indexing instead of the generic path, producing non-square sub-blocks. Fix uses block_size for alignment checks, detects cross-block slices and falls back to the generic super()._getitem(), and selects blocks from the batch dimension rather than passing block indices as matrix row/col indices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modulo check used num_blocks instead of block_size, so slices aligned to individual blocks (e.g. bd[:12, :12] with block_size=12) were incorrectly handled. Cross-block slices (row blocks != col blocks) fell through to block-level indexing instead of the generic path, producing non-square sub-blocks.
Three fixes: