feat: support for multi gRPC query clients serve with old binary #25565
+644
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25565 +/- ##
==========================================
+ Coverage 68.39% 70.29% +1.90%
==========================================
Files 856 821 -35
Lines 55773 53780 -1993
==========================================
- Hits 38144 37807 -337
+ Misses 17629 15973 -1656
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
3 tasks
aljo242
reviewed
Nov 18, 2025
aljo242
reviewed
Nov 18, 2025
Contributor
aljo242
left a comment
aljo242
left a comment
There was a problem hiding this comment.
Overall this looks good to me - mainly just wanting a bit more documentation and testing :)
Co-authored-by: Alex | Cosmos Labs <[email protected]>
aljo242
approved these changes
Nov 19, 2025
Contributor
aljo242
left a comment
aljo242
left a comment
There was a problem hiding this comment.
LGTM with just tiny nits
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
) Co-authored-by: Alex | Cosmos Labs <[email protected]> (cherry picked from commit f4e2ce0) # Conflicts: # server/start.go
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/cosmos-sdk
that referenced
this pull request
Nov 19, 2025
aljo242
added a commit
that referenced
this pull request
Nov 19, 2025
…kport #25565) (#25580) Co-authored-by: mmsqe <[email protected]> Co-authored-by: aljo242 <[email protected]>
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Nov 21, 2025
…kport cosmos#25565) (cosmos#25580) Co-authored-by: mmsqe <[email protected]> Co-authored-by: aljo242 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #25564, for test info