ci: add manual testing for besu chains#999
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dd1c9b5d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elType, elImage = GetKurtosisELImageAndType() | ||
| clType, clImage = GetKurtosisCLImageAndType() |
There was a problem hiding this comment.
GetKurtosisELImageAndType and GetKurtosisCLImageAndType return values as (image, type), but these assignments bind them as (type, image). That inverts the participant config (ELType becomes an image tag like ethereum/client-go:v1.16.8, while ELImage becomes geth, and likewise for CL), so the serialized Kurtosis parameters contain invalid client type/image fields and PoS testnet startup will fail in both default and manual besu workflow runs.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 27 27
Lines 1123 1123
=======================================
Hits 1122 1122
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.