Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves observability for memdx-layer failures by including the underlying source error (when present) in the Display output for memdx::error::Error. This helps warnings like “failed to read frame” carry the originating I/O/protocol error details without requiring Debug formatting or explicit source-chain traversal.
Changes:
- Extend
memdx::error::Error’sDisplayimplementation to append: {source}whenError::source()is available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bencher Report| Branch | RSCBC-282-29427487872-187-1 |
| Testbed | ubuntu-latest |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| query | Latency microseconds (µs) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 486.02 µs(+15.44%)Baseline: 421.03 µs | 484.19 µs (100.38%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 486.02 µs(+15.44%)Baseline: 421.03 µs | 484.19 µs (100.38%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 458.63 µs(+13.82%)Baseline: 402.93 µs | 463.37 µs (98.98%) |
|
| Branch | RSCBC-282-29427487872-187-2 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 326.63 µs(-22.42%)Baseline: 421.03 µs | 484.19 µs (67.46%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 312.88 µs(-22.35%)Baseline: 402.93 µs | 463.37 µs (67.52%) |
chvck
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Displayimplementation of a memdx error, if there is one