Conversation
There was a problem hiding this comment.
Pull request overview
Fixes query index creation so nested field paths (e.g. d.firstName) can be indexed correctly, avoiding the previous behavior where the SDK wrapped the entire string as a single escaped identifier (e.g. `d.firstName`).
Changes:
- Stop escaping
CreateIndexOptions.fieldswhen building the CREATE INDEX statement so callers can provide nested paths / explicit quoting. - Preserve existing behavior for other parts of the statement (e.g., keyspace building, WITH options, error handling).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bencher Report| Branch | RSCBC-285-29503958206-188-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 449.41 µs(+6.74%)Baseline: 421.03 µs | 484.19 µs (92.82%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 419.47 µs(+4.10%)Baseline: 402.93 µs | 463.37 µs (90.53%) |
|
| Branch | RSCBC-285-29504345289-189-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 442.10 µs(+5.00%)Baseline: 421.03 µs | 484.19 µs (91.31%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 419.33 µs(+4.07%)Baseline: 402.93 µs | 463.37 µs (90.50%) |
chvck
reviewed
Jul 16, 2026
chvck
left a comment
chvck
left a comment
Contributor
There was a problem hiding this comment.
We should probably have a test for this
|
| Branch | RSCBC-285-29517304317-190-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 453.43 µs(+7.71%)Baseline: 420.97 µs | 484.11 µs (93.66%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 435.49 µs(+9.39%)Baseline: 398.11 µs | 457.82 µs (95.12%) |
chvck
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the create_index escapes the fields that are passed in, this means that a field like
d.firstNamewas parsed as '`d.firstName`' and not '`d`.`firstName`'. This meant that it was not possible to index nested fields properly. Likewise in the case when backticks were needed in the field name itself, escaping the backticks would cause the server to return a syntax error.Changes
Stop escaping index field names and pass them as is to allow indexing nested fields
Notes
This change may break anyone who was relying on the SDK escaping the index names, e.g. trying to index non-nested fields with dots in their name, or when reserved words are used, in which case backticks will have to be added to the user's field input.