Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the XDCR CheckDocument RPC flow to recognize and surface a “document locked” condition, returning a FailedPrecondition status (with PreconditionFailure details) instead of proceeding with conflict resolution logic.
Changes:
- Added a
DocLockedsubtest to ensureCheckDocumentreturnscodes.FailedPreconditionwith aLOCKEDviolation when the target document is locked. - Updated
XdcrServer.CheckDocumentto detect the locked-document condition (via a special CAS value) and return aDocLockedstatus.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gateway/test/xdcr_test.go | Adds test coverage asserting CheckDocument fails with LOCKED when the document is locked. |
| gateway/dataimpl/server_v1/xdcrserver.go | Adds locked-document detection in CheckDocument and returns a FailedPrecondition error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brett19
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.