Skip to content

fixes ci issue, proper type safety #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briheet merged 1 commit into from
Mar 5, 2026
Merged

fixes ci issue, proper type safety #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/gen_worker/cozy_snapshot_v2_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ async def _ensure_one(f: CozyHubSnapshotFile, digest: str, dst: Path) -> None:
async with lock:
if dst.exists():
return
assert f.url is not None
await _download_one_file(
f.url,
dst,
Expand Down
20 changes: 10 additions & 10 deletions src/gen_worker/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
from .model_interface import ModelManagementInterface
from .downloader import CozyHubDownloader, ModelDownloader
from .model_ref_downloader import ModelRefDownloader
from .model_refs import parse_model_ref
from .model_refs import ParsedModelRef, parse_model_ref
from .types import Asset
from .model_cache import ModelCache, ModelCacheStats, ModelLocation
from .run_metrics_v1 import RunMetricsV1, best_effort_bytes_downloaded, best_effort_init_model_metrics, safe_json_bytes
Expand Down Expand Up @@ -4623,28 +4623,28 @@ def _resolve_injected_value(self, ctx: ActionContext, requested_type: Any, model
from_pretrained = getattr(requested_type, "from_pretrained")
model_source: str = str(model_id)
preload_kwargs: dict[str, Any] = {}
parsed = None
_ref: ParsedModelRef | None = None
try:
p = Path(model_source)
if p.exists():
model_source = p.as_posix()
else:
parsed = parse_model_ref(model_source)
if parsed.scheme in ("cozy", "hf") and self._downloader is not None:
_ref = parse_model_ref(model_source)
if _ref.scheme in ("cozy", "hf") and self._downloader is not None:
model_source = self._downloader.download(model_source, str(worker_model_cache_dir()))
elif parsed.scheme == "hf" and parsed.hf is not None:
elif _ref.scheme == "hf" and _ref.hf is not None:
# Fallback path when downloader is unavailable.
model_source = parsed.hf.repo_id
if parsed.hf.revision:
preload_kwargs["revision"] = parsed.hf.revision
elif parsed.scheme == "cozy":
model_source = _ref.hf.repo_id
if _ref.hf.revision:
preload_kwargs["revision"] = _ref.hf.revision
elif _ref.scheme == "cozy":
raise RuntimeError(
f"cozy model resolution requires downloader for ref {model_source!r}"
)
except Exception as e:
# Never hand raw cozy refs to huggingface loaders; surface the real
# download/resolve error instead of falling back to repo-id parsing.
if parsed is not None and getattr(parsed, "scheme", "") == "cozy":
if _ref is not None and getattr(_ref, "scheme", "") == "cozy":
raise RuntimeError(
f"cozy model materialization failed for {model_id!r}: {e}"
) from e
Expand Down