Skip to content

fix: remove duplicate ICT and PHT timezone entries#108

Merged
atoomic merged 1 commit into
cpan-authors:mainfrom
Koan-Bot:koan.atoomic/fix-duplicate-tz-entries
Apr 26, 2026
Merged

fix: remove duplicate ICT and PHT timezone entries#108
atoomic merged 1 commit into
cpan-authors:mainfrom
Koan-Bot:koan.atoomic/fix-duplicate-tz-entries

Conversation

@Koan-Bot
Copy link
Copy Markdown

@Koan-Bot Koan-Bot commented Apr 11, 2026

What

Removes duplicate ICT (Indochina Time) and PHT (Philippine Time) definitions from @Zone in Time::Zone.

Why

Both timezones were defined twice with identical values. The second definition silently overwrites the first — no behavioral change, but it's confusing and suggests a copy-paste error during a previous timezone addition.

Testing

Full test suite passes (28 files).

🤖 Generated with Claude Code


Quality Report

Changes: 1 file changed, 2 insertions(+), 4 deletions(-)

Code scan: clean

Tests: skipped

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline

ICT (Indochina Time) and PHT (Philippine Time) were each defined twice
in @zone, causing the second definition to silently overwrite the first.
Both duplicates had identical values so no behavioral change.

Co-Authored-By: Claude <noreply@anthropic.com>
@atoomic atoomic marked this pull request as ready for review April 26, 2026 12:51
@atoomic atoomic merged commit 46ae10e into cpan-authors:main Apr 26, 2026
22 checks passed
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 26, 2026

Greptile Summary

Removes two duplicate key-value pairs ("ict" and "pht") from the @Zone array in lib/Time/Zone.pm. In Perl, %Zone = @Zone means duplicate keys are silently overwritten by the last occurrence, so there was no behavioral change — this is purely a cleanup of redundant copy-paste entries.

Confidence Score: 5/5

Safe to merge — purely cosmetic deduplication with no behavioral change.

The removed entries had identical values to the retained entries; the hash initialization semantics in Perl (%Zone = @zone) already silenced the first duplicate. No logic, values, or external contracts change.

No files require special attention.

Important Files Changed

Filename Overview
lib/Time/Zone.pm Removes the first (less-descriptively commented) duplicate definitions of "ict" (Indochina Time, +7h) and "pht" (Philippine Time, +8h); no functional change since %Zone = @zone would already keep the last occurrence.

Reviews (1): Last reviewed commit: "fix: remove duplicate ICT and PHT timezo..." | Re-trigger Greptile

@Koan-Bot Koan-Bot deleted the koan.atoomic/fix-duplicate-tz-entries branch April 27, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants