fix: remove duplicate ICT and PHT timezone entries#108
Merged
atoomic merged 1 commit intoApr 26, 2026
Conversation
ICT (Indochina Time) and PHT (Philippine Time) were each defined twice in @zone, causing the second definition to silently overwrite the first. Both duplicates had identical values so no behavioral change. Co-Authored-By: Claude <noreply@anthropic.com>
atoomic
approved these changes
Apr 26, 2026
Greptile SummaryRemoves two duplicate key-value pairs ( Confidence Score: 5/5Safe to merge — purely cosmetic deduplication with no behavioral change. The removed entries had identical values to the retained entries; the hash initialization semantics in Perl (%Zone = @zone) already silenced the first duplicate. No logic, values, or external contracts change. No files require special attention.
|
| Filename | Overview |
|---|---|
| lib/Time/Zone.pm | Removes the first (less-descriptively commented) duplicate definitions of "ict" (Indochina Time, +7h) and "pht" (Philippine Time, +8h); no functional change since %Zone = @zone would already keep the last occurrence. |
Reviews (1): Last reviewed commit: "fix: remove duplicate ICT and PHT timezo..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes duplicate ICT (Indochina Time) and PHT (Philippine Time) definitions from
@ZoneinTime::Zone.Why
Both timezones were defined twice with identical values. The second definition silently overwrites the first — no behavioral change, but it's confusing and suggests a copy-paste error during a previous timezone addition.
Testing
Full test suite passes (28 files).
🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 2 insertions(+), 4 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline