fix: correct spelling errors in Austrian and Romanian modules#118
Conversation
Austrian: October abbreviation was "Oct" (English) instead of "Okt" (German). All other abbreviations used the correct German forms. Romanian: November was misspelled as "noembrie" instead of "noiembrie". Also fixed the file header comment which said "Italian tables" (copy-paste artifact from Italian.pm). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| our @MoY = qw(Jänner Feber März April Mai Juni | ||
| Juli August September Oktober November Dezember); | ||
| our @MoYs = qw(Jän Feb Mär Apr Mai Jun Jul Aug Sep Oct Nov Dez); | ||
| our @MoYs = qw(Jän Feb Mär Apr Mai Jun Jul Aug Sep Okt Nov Dez); |
There was a problem hiding this comment.
looks correct
my %months_de_at = (
October => {
full => "Oktober",
abbr => "Okt.",
},
);
|
|
||
| @MoY = qw(ianuarie februarie martie aprilie mai iunie | ||
| iulie august septembrie octombrie noembrie decembrie); | ||
| iulie august septembrie octombrie noiembrie decembrie); |
There was a problem hiding this comment.
looks correct too
my %en_to_ro = (
November => "noiembrie",
);
Greptile SummaryThis PR makes three minimal, targeted data corrections: the Austrian October abbreviation is fixed from Confidence Score: 5/5Safe to merge — all changes are one-character data corrections backed by regression tests, with no logic changes. All three fixes are straightforward and correct. The only finding is a P2 wrong date string in a test comment; the test itself functions correctly and the data fixes are accurate. No files require special attention; the minor comment inaccuracy in t/lang-data.t is cosmetic only.
|
| Filename | Overview |
|---|---|
| lib/Date/Language/Austrian.pm | Corrects October abbreviation in @moys from "Oct" (English) to "Okt" (German), consistent with all other German-form abbreviations in the array. |
| lib/Date/Language/Romanian.pm | Fixes two copy-paste artifacts: stale "Italian tables" header comment updated to "Romanian tables", and November spelling corrected from "noembrie" to "noiembrie". |
| t/lang-data.t | Adds two regression tests for the fixes; test logic is correct but the comment for oct_time incorrectly states "Thu Oct 14" when the timestamp is actually Wed Oct 13 1999 UTC. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["time2str('%b', $oct_time)"] --> B["Austrian::format_b"]
B --> C["@MoYs[ mon ]"]
C -->|"mon=9 (October)"| D["Before: 'Oct' ❌"]
C -->|"mon=9 (October)"| E["After: 'Okt' ✅"]
F["time2str('%B', $nov_time)"] --> G["Romanian::format_B"]
G --> H["@MoY[ mon ]"]
H -->|"mon=10 (November)"| I["Before: 'noembrie' ❌"]
H -->|"mon=10 (November)"| J["After: 'noiembrie' ✅"]
Reviews (1): Last reviewed commit: "fix: correct spelling errors in Austrian..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| # Regression: Austrian October abbreviation must be "Okt" (German), not "Oct" (English) | ||
| { | ||
| my $at = Date::Language->new('Austrian'); | ||
| # Thu Oct 14 12:00:00 1999 UTC — mon=9 (October) |
There was a problem hiding this comment.
The comment says Thu Oct 14 12:00:00 1999 UTC but 939816000 actually corresponds to Wed Oct 13 12:00:00 1999 UTC (verified with gmtime). The test logic is correct — October 13 is still in October (month index 9), so "Okt" is returned as expected — but the comment is misleading.
| # Thu Oct 14 12:00:00 1999 UTC — mon=9 (October) | |
| # Wed Oct 13 12:00:00 1999 UTC — mon=9 (October) |
2 participants
What
Fixes incorrect month names in
Date::Language::AustrianandDate::Language::Romanian.Why
How
Minimal data corrections — one character each for Austrian and Romanian. Added targeted regression tests in
lang-data.t.Testing
prove -l t/— all tests pass.🤖 Generated with Claude Code