chore: redadct url param secrets in logs #1522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Nov 8, 2025
Owner
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Thanks for your contrib!
I do agree that tokens should not leak in the logs but I'm not really a fan of pattern matching to filter those.
I opened #1530 so instead of setting the Gotify token as query param it will be set as a header instead.
Author
|
Sounds good! Thank you so much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got this error message when trying to set up diun with Gotify, with the auth token in plaintext, which can be insecure (CWE-117 / CWE-532).
Sat, 11 Oct 2025 12:00:04 PDT ERR Gotify notification failed error="Post \"http://gotify:9265/message?token=xxx\": dial tcp 172.20.0.3:9265: connect: connection refused" image=docker.io/searxng/searxng:latestThis PR adds sanitization for logged URLs/paths (based on common param names for secrets) while logging and adds tests.