Skip to content

fix: rename PLATFORM_WALLET_PASSWORD to PLATFORM_WALLET_KEY #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Duzzann wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: rename PLATFORM_WALLET_PASSWORD to PLATFORM_WALLET_KEY #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f8fc31
fix: rename PLATFORM_WALLET_PASSWORD to PLATFORM_WALLET_KEY
Duzzann Oct 10, 2025
b3f9712
fix: update comment in .env.sample to PLATFORM_WALLET_KEY
Duzzann Oct 10, 2025
70a48f2
fix: update env demo and agent service
Duzzann Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.demo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ [email protected]
AFJ_VERSION=ghcr.io/credebl/credo-controller:latest

PLATFORM_WALLET_NAME=platform-admin
PLATFORM_WALLET_PASSWORD='U2FsdGVkX19l6w/PpuicnGBYThBHolzF27oN0JwfWkc='
PLATFORM_WALLET_KEY='U2FsdGVkX19l6w/PpuicnGBYThBHolzF27oN0JwfWkc='
Copy link

@coderabbitai coderabbitai bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix trailing whitespace.

There is trailing whitespace at the end of line 53. Please remove it to maintain consistent formatting.

Apply this diff to remove the trailing whitespace:

-PLATFORM_WALLET_KEY='U2FsdGVkX19l6w/PpuicnGBYThBHolzF27oN0JwfWkc=' 
+PLATFORM_WALLET_KEY='U2FsdGVkX19l6w/PpuicnGBYThBHolzF27oN0JwfWkc='
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
PLATFORM_WALLET_KEY='U2FsdGVkX19l6w/PpuicnGBYThBHolzF27oN0JwfWkc='
PLATFORM_WALLET_KEY='U2FsdGVkX19l6w/PpuicnGBYThBHolzF27oN0JwfWkc='
🧰 Tools
🪛 dotenv-linter (3.3.0)

[warning] 53-53: [TrailingWhitespace] Trailing whitespace detected

(TrailingWhitespace)

[warning] 53-53: [UnorderedKey] The PLATFORM_WALLET_KEY key should go before the PLATFORM_WALLET_NAME key

(UnorderedKey)

🪛 Gitleaks (8.28.0)

[high] 53-53: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

🤖 Prompt for AI Agents 
In .env.demo around line 53, the line containing PLATFORM_WALLET_KEY has a
trailing whitespace character at the end; remove that trailing space so the line
ends immediately after the value (no extra spaces or tabs), save the file, and
ensure no other trailing whitespace remains on that line.

PLATFORM_SEED=000000000000000000000000Steward1
PLATFORM_ID=1

Expand Down
2 changes: 1 addition & 1 deletion .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ AFJ_VERSION=afj-0.4.1:latest
FIDO_API_ENDPOINT=http://localhost:8000 # Host:port of your FIDO (WebAuthn) Server

PLATFORM_WALLET_NAME=platform-admin
PLATFORM_WALLET_PASSWORD= // Please provide encrypt password using crypto-js
PLATFORM_WALLET_KEY= // Please provide encrypt key using crypto-js
PLATFORM_SEED= // The seed should consist of 32 characters.
PLATFORM_ID=

Expand Down
2 changes: 1 addition & 1 deletion apps/agent-service/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ async function bootstrap(): Promise<void> {

const agentSpinupPayload: IAgentSpinupDto = {
walletName: process.env.PLATFORM_WALLET_NAME,
walletPassword: process.env.PLATFORM_WALLET_PASSWORD,
walletPassword: process.env.PLATFORM_WALLET_KEY,
Copy link

@coderabbitai coderabbitai bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix trailing whitespace.

There is trailing whitespace at the end of line 32. Please remove it to maintain consistent formatting.

Apply this diff to remove the trailing whitespace:

-    walletPassword: process.env.PLATFORM_WALLET_KEY, 
+    walletPassword: process.env.PLATFORM_WALLET_KEY,
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
walletPassword: process.env.PLATFORM_WALLET_KEY,
walletPassword: process.env.PLATFORM_WALLET_KEY,
🤖 Prompt for AI Agents 
In apps/agent-service/src/main.ts around line 32, there's a trailing whitespace
at the end of the line containing "walletPassword:
process.env.PLATFORM_WALLET_KEY,"; remove the extra space character at
end-of-line so the line ends exactly with the comma (or adjust punctuation if
intended), then save the file and run formatter/linter to ensure consistent
formatting.

seed: process.env.PLATFORM_SEED,
orgName: `${CommonConstants.PLATFORM_ADMIN_ORG}`,
platformAdminEmail: process.env.PLATFORM_ADMIN_EMAIL,
Expand Down