Skip to content

Conversation

@devdgna
Copy link

@devdgna devdgna commented Nov 17, 2025

Summary

  • Introduce scripts/targets for consistent local and CI builds.
  • Apply minor fixes to satisfy lint/tests and improve reliability.
    @ankita-p17 pls delegate the task to concerned personnel for review and merge.

Dev added 2 commits November 17, 2025 15:13
…e to credebl/platform@main\n\n- Base: upstream/main\n- Snapshot: contents from fork branch pipeline-implementation\n- Purpose: enable opening a PR from fork to upstream despite unrelated histories
@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

81 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
55 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@devdgna devdgna changed the title Align Ngotag fork with creadebl main Sync CREDEBL main to NGOTAG Nov 17, 2025
@devdgna devdgna changed the title Sync CREDEBL main to NGOTAG Sync CREDEBL with NGOTAG Nov 17, 2025
@GHkrishna
Copy link
Contributor

GHkrishna commented Nov 18, 2025

Hi @devdgna
Thank you for the PR, can you please look into the failing DCO?

You can follow the steps mentioned here: https://github.com/credebl/platform/pull/1519/checks?check_run_id=55568919994

@GHkrishna GHkrishna added the enhancement Improving existing code or adding enhancement label Nov 18, 2025
@GHkrishna
Copy link
Contributor

One more thing to note is since this is a sync PR, we ideally shouldn't be making a PR directly to CREDEBL.

If we look at the file changes, we are actually reverting the changes made since the last pull(in your repo), which is taking CREDEBL back to its initial state, losing all the progress made since then.

A better way would be to instead make a PR, including only features specifically added on top of CREDEBL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving existing code or adding enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants