VirtualBox smoke test: cover default graphics and launch the installer (#218) - #224
Merged
Merged
Conversation
…launch (Refs #218) smoke-iso.sh gains --graphics default|vboxsvga (SPACED_VBOX_GRAPHICS): default leaves VirtualBox's own VMSVGA defaults in place and records the chosen controller, while vboxsvga keeps today's forced settings. The expected default-profile outcome (Compiz cannot start) is reported distinctly as NO WINDOW MANAGER with exit 3, diagnosed via the spaced-window-manager logger message, compiz process state, and wmctrl -m, instead of timing out ambiguously. Both profiles now launch /usr/local/bin/install-spaced-linux over SSH after the desktop is up, wait up to 90s for a calamares process and window, screenshot it, and close it without installing. Makefile gains vbox-smoke and vbox-smoke-default; release docs and check.sh cover both. No CI change: hosted runners cannot run VirtualBox.
The BIOS run's documented exit 3 (no window manager, #218) stopped make before the EFI run. Treat 3 as the known result so both profiles run; any other failure still fails the target. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0157UgH4vsxpmbozsNLjJ42m
Deploying spaced-linux with
|
| Latest commit: |
7e9f063
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48801e7f.spaced-linux.pages.dev |
| Branch Preview URL: | https://test-218-virtualbox-default.spaced-linux.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #218. The VirtualBox smoke test forced VBoxSVGA and never launched the installer, so it could not catch what users hit with VirtualBox's default VMSVGA adapter.
scripts/vm/virtualbox/smoke-iso.sh --graphics default|vboxsvga(orSPACED_VBOX_GRAPHICS);vboxsvgais today's behaviour.defaultpasses no graphics flags and records the controller VirtualBox chose.0desktop and installer usable,3live session reached but no window manager (Compiz cannot start),1/2other or usage failures. Ondefault, no-WM is confirmed three times to avoid false positives during slow Compiz startup.install-spaced-linuxas the live user, waits up to 90 s for a Calamares process and a visible window, takes a screenshot, and closes it without installing.make vbox-smoke(VBoxSVGA, BIOS+EFI) andmake vbox-smoke-default(VirtualBox defaults, BIOS+EFI; exit 3 is the expected result until Trying SpacedLinux v29.26.2 as Virtual Machine. Install Spaced Linux will not launch #218 is fixed). The release checklist is documented in README.md and docs/9.26-TESTING.md. Not added to GitHub Actions, since hosted runners cannot run VirtualBox.tests/test_vbox_smoke.pyplus check.sh assertions.shellcheck -S warningis clean. No VM was booted in this change.Verified:
check.shpassed; 103 unit tests OK. Reviewer fix:vbox-smoke-defaulttreats exit 3 as expected so the EFI run is not skipped after BIOS.Maintainer to run:
make vbox-smoke(expect exit 0, screenshots underbuild/test-artifacts/) andmake vbox-smoke-default(expect "NO WINDOW MANAGER" with controller VMSVGA today).Implemented by Muse Spark 1.3 (opencode); reviewed by Claude.
🤖 Generated with Claude Code
https://claude.ai/code/session_0157UgH4vsxpmbozsNLjJ42m