Conversation
|
|
||
| int threadCount = 50; | ||
| CountDownLatch startLatch = new CountDownLatch(1); | ||
| ExecutorService executor = Executors.newFixedThreadPool(threadCount); |
There was a problem hiding this comment.
Can we use ConcurrentTest from our test-utils here?
We might need to extend it a bit. That would make sense anyway IMO.
There was a problem hiding this comment.
I think since we only use Java 8 here I cannot use test-utils.
There was a problem hiding this comment.
Wouldn’t it be time to raise the min required Java version? IMO we can require Java 17+
There was a problem hiding this comment.
I have no strong opinion on this. I guess at some point one might want to use newer features in the validation file api, but currently there is no pressure to do it.
|
|
||
| wrapper { | ||
| gradleVersion = "7.0" | ||
| gradleVersion = "8.10.2" |
There was a problem hiding this comment.
That should be part of the next commit. IMO we should bump it to 9.5.0
There was a problem hiding this comment.
Ups. Fixed.
And I think gradle 9 does not work with java 8.
Pin JUnit to 5.x due to Java 8 incompatibility with JUnit 6
At least 17 is required for spotless
2 participants
No description provided.