Fix 1840#1895
Merged
Merged
Conversation
The check-typing recipe now runs `ruff check --select ANN,UP,TCH` (annotation presence, pyupgrade modern syntax, TYPE_CHECKING imports) on src/autobahn/ before the ty check, so annotation/style regressions are caught in the CI quality-checks job. src/autobahn/ currently has ~3800 missing-annotation findings, so the ANN codes (and the 3 TC00x currently present) are ratcheted via an explicit --ignore allowlist to be removed module-by-module (crossbario#1839); every other UP and TC rule is enforced immediately. Generated code (flatbuffers/, wamp/gen/, message_fbs.py) is excluded via [tool.ruff] plus --force-exclude. Deviation from the issue as written: the annotation rules are scoped to this recipe via the command-line --select rather than the global [tool.ruff.lint] select, because check-format runs `ruff check .` off that config and would otherwise turn red with all ~3800 findings. The proposed `required-imports = ["from __future__ import annotations"]` is also omitted (it is the eager annotation-eval hazard behind crossbario#1878). Only the safe [tool.ruff.lint.flake8-annotations] tuning was added to pyproject.toml. check-typing now also depends on (install-tools venv) so the venv ruff is present when run standalone. Verified green end-to-end (ruff + ty) on cpy311. Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1840