-
Notifications
You must be signed in to change notification settings - Fork 108
Add doc on managing CRD versions #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jean du Plessis <[email protected]>
sergenyalcin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jeanduplessis, for this doc. I left a few comments to clarify some points.
Address review comments from PR #539: - Clarify that Upjet does not generate default values in CRD schema - Fix statement about CRD generation (only latest version is generated) - Add distinction between storage version and hub version - Document SetCRDStorageVersion and SetCRDHubVersion configuration options 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Address review comments from PR #539: - Clarify that Upjet does not generate default values in CRD schema - Fix statement about CRD generation (only latest version is generated) - Add distinction between storage version and hub version - Document SetCRDStorageVersion and SetCRDHubVersion configuration options 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Jean du Plessis <[email protected]>
992d8d1 to
d50c596
Compare
|
@sergenyalcin thanksfor the review. I've made the following updates:
|
sergenyalcin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeanduplessis LGTM!
Description of your changes
Takes the information from the discussion in #529 (comment) and creates a documentation page for guidance on managing CRD versions,.
Fixes #529
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
n/a