Skip to content

fix: WebView crashes caused by wrapped context resources #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
+8 −1
Draft

fix: WebView crashes caused by wrapped context resources #321

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80355fc
Initial plan
Copilot Nov 13, 2025
4a68a43
Fix: Use application context resources to prevent WebView crashes
Copilot Nov 13, 2025
9b07ea0
Add unit test for CrowdinContextWrapper
Copilot Nov 13, 2025
6c93c46
Fix formatting and remove problematic test
Copilot Nov 14, 2025
38561b0
Fix ktlint trailing comma issue
Copilot Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion crowdin/src/main/java/com/crowdin/platform/CrowdinContextWrapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ internal class CrowdinContextWrapper private constructor(
) : ContextWrapper(
CustomResourcesContextWrapper(
base,
CrowdinResources(base.resources, dataManager),
// Use application context resources to ensure we have access to all system resources
// This prevents crashes when WebView or other system components try to inflate views
// See: https://github.com/crowdin/mobile-sdk-android/issues/220
// See: https://github.com/crowdin/mobile-sdk-android/issues/266
CrowdinResources(
base.applicationContext?.resources ?: base.resources,
dataManager,
),
),
) {
override fun getSystemService(name: String): Any? {
Expand Down
Loading