Skip to content

ci(pr): ensure correct ref is checked out - #136

Merged
andrewazores merged 1 commit into
cryostatio:mainfrom
andrewazores:pr-ci-checkout
Oct 30, 2026
Merged

andrewazores merged 1 commit into
cryostatio:mainfrom
andrewazores:pr-ci-checkout

Conversation

@andrewazores

Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


PR CI checks out the wrong ref and effectively is just testing main, not the PR's changes, so PRs look safe to merge when they may not actually be.

@andrewazores
andrewazores merged commit 68e36b3 into cryostatio:main Oct 30, 2026
16 of 18 checks passed
@andrewazores
andrewazores deleted the pr-ci-checkout branch October 30, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant