Update ci.yml

[cpaolini]

Remove changes applied to branch test/clang-tidy.

What type of PR is this? (check all applicable)

• Refactor
• [ X ] Feature
• Bug Fix
• Optimization
• Example
• Documentation

Description

Enable invocation of the clang-tidy C/C++ linter tool within the Build, Test, and Documentation workflow.

Related Issues & Documents

• [ X ] I have created an Issue that is paired with this PR
• Closes Enable static analysis and linting for C and C++ sources via clang-tidy #281 (Enable static analysis and linting for C and C++ sources via clang-tidy)

QA Instructions, Screenshots, Recordings

View https://github.com/csrc-sdsu/mole/actions and monitor status and outcome of a Build, Test, and Documentation workflow. Address "clang-tidy (fail on warnings/errors) output and correct C / C++ code issues flagged.

Added/updated tests?

_We encourage you to test all code included with MOLE, including examples.

• [ X ] Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

Read Contributing Guide and Code of Conduct

• [ X ] 📖 I have read the MOLE Contributing Guide: https://github.com/csrc-sdsu/mole/blob/main/CONTRIBUTING.md
• [ X ] 📖 I have read the MOLE Code of Conduct: https://github.com/csrc-sdsu/mole/blob/main/CODE_OF_CONDUCT.md

[optional] Are there any post deployment tasks we need to perform?

Address "clang-tidy (fail on warnings/errors) output and correct C / C++ code issues flagged.

[optional] What gif best describes this PR or how it makes you feel?

https://media0.giphy.com/media/v1.Y2lkPTc5MGI3NjExMXNlNW10cml3YjhsODFheW0wcWloODgzNnhnNWswNGN0bXJ4dTB4diZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/NoguHv9Gyz064/giphy.gif

[valeriabarra]

Hi @cpaolini , I am not sure I entirely follow the logs, but I saw there are some errors.

[cpaolini]

@valeriabarra Greetings. These SuperLinter errors have been fixed in branch test/super-linter. See

Update ci.yml #548

in Recompile-JOSS-paper and Build-Documentation I changed

echo "changed=true" >> $GITHUB_OUTPUT
echo "changed=false" >> $GITHUB_OUTPUT

to

echo "changed=true" >> "$GITHUB_OUTPUT"
echo "changed=false" >> "$GITHUB_OUTPUT"

Unquoted variable expansions trigger SuperLinter errors.

Thank you,

Chris