-
Notifications
You must be signed in to change notification settings - Fork 111
Build improvements #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.10.2
Are you sure you want to change the base?
Build improvements #174
Conversation
|
Thanks @scordio ! A question here: Is the |
|
Yes, they're generated by the following execution: Feel free to drop mine and regenerate them, just to reconfirm that there are no customizations 🙂 |
|
Should these generated scripts be committed into version control? |
|
Yes, they are usually committed especially to be used in the CI jobs or locally, so that the project locks in the Maven version to be used and doesn't depend on the running environment. |
0ee19fe to
3e494f5
Compare
|
@ctongfei I noticed you changed the base branch, so I rebased the PR accordingly 👍 |
|
Hi @ctongfei, in case there is something I should adjust further, feel free to let me know! |
|
Sorry for not being active on this. I'll check if this interferes with how I publish these to Maven. If it works properly I'll merge |
|
No worries! Have you considered automating the release process via GitHub Actions? In case you're interested, I'd be happy to raise a separate MR for it (along the lines of What's worth mentioning is that A simple example where I've migrated to it is at assertj/assertj-generator#273. |
I noticed that the project doesn't have a CI configuration.
I think it would help contributors' experience to have one, so this PR:
mvn org.apache.maven.plugins:maven-wrapper-plugin:3.3.2:wrapper -Dmaven=3.9.9pluginManagementsection and upgrade all plugins to the latest versionmaven-gpg-pluginandnexus-staging-maven-pluginplugins