Add parentheses in allowed column pattern for commented columns#1000
Open
m11o wants to merge 1 commit intoctran:developfrom
Open
Add parentheses in allowed column pattern for commented columns#1000m11o wants to merge 1 commit intoctran:developfrom
m11o wants to merge 1 commit intoctran:developfrom
Conversation
the annotation of model which has commented column is not updated even if the column will be updated options of the column.
m11o
commented
Dec 3, 2023
Comment on lines
+3096
to
+3099
| change { File.read(@model_file_name) } | ||
| .from(include("name(commented column) :string\n")) | ||
| .to(include("name(commented column) :string not null\n")) | ||
| ) |
Author
There was a problem hiding this comment.
If parentheses aren't added, this annotation isn't updated and this test is failed with the following error.
1) AnnotateModels annotating a file if a table has a commented column and the model already has annotation and the commented column is updated to non-null should be added non-null option in the commented column
Failure/Error:
expect do
AnnotateModels.annotate_one_file(@model_file_name, schema_info, :position_in_class, @annotation_options)
end.to change { File.read(@model_file_name) }
.from(include("name(commented column) :string\n"))
.to(include("name(commented column) :string not null\n"))
expected `File.read(@model_file_name)` to have changed from include "name(commented column) :string\n" to include "name(commented column) :string not null\n", but did not change
# ./spec/lib/annotate/annotate_models_spec.rb:3087:in `block (5 levels) in <top (required)>'
BryanH
approved these changes
Dec 11, 2023
topalovic
added a commit
to zero44gmbh/annotate_models
that referenced
this pull request
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parentheses in allowed column pattern for commented columns.
The annotation of a model with commented columns is not updated even if the column will be updated.
Steps to reproduce