Repository navigation
Update to fix where max_length.size was not returning expected value - #669
Merged
Merged
Conversation
droberts-ctrlo
force-pushed
the
max-length-fix
branch
from
October 5, 2026 14:14
f4bfb71 to
621bc14
Compare
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - no comments from me.
droberts-ctrlo
force-pushed
the
max-length-fix
branch
from
October 7, 2026 10:02
9701626 to
412f55d
Compare
droberts-ctrlo
added a commit
to droberts-ctrlo/GADS
that referenced
this pull request
Oct 13, 2026
* Fix regression of performance * Update changelog * Fix unable to clone records with curvals containing created user field * Allow read-only values to be used in filtered curvals This commit facilitates the situation where a filtered curval is using a read-only (populated) field in an existing record. * New version release * Fix exceptions when using person field typeahead * View All now visible on all curvals * Added and updated breadcrumbs * Modified sort Updated sort to allow sorting in view by multiple columns * Fix for user permissions not saving Typo in `wizz?ard` was causing permissions to not be saved * Found bug in display conditions and fixed (ctrlo#474) * Updated for less use of `any` * Updated with fix for display conditions not saving on first save * Fix for Typeaheads not working as expected with curvals (ctrlo#482) * Fix for Typeaheads not working as expected with curvals * Update component.js * Updated ts to ignore errors (ctrlo#485) * Updated ts to ignore errors * Update autocompleteComponent.ts * Update app.tsx * Rebuild JS * Bump version * Updated curvals to work as expected * Fix for user permissions not saving correctly * Fix indentation * Rebuild JS * Create release * Fix for datatables loading graphic displaying in the incorrect place * Fix for user notes not persisting when saving users * Added mandatory values to registration * Updated code to call edit user code correctly * Removed buffer from timeline code Buffer was still present in timeline code - this has been removed in favour of preferred `atob` method * Addition of deleted date to person field [B: 1742] (ctrlo#484) * Addition of deleted date to person field * Removed as_epoch * Implement cutom reason for account request rejection * Added nil checks on person deleted field (ctrlo#502) * Added "view all" option to curvals [B: 1734] (ctrlo#498) * Fix for error when trying to deselect tree value When the tree is a multi-value field, there is bug where deselecting nodes causes the screen to "jump" to the top of the form and making deselecting values complicated. * Remove unnecessary building of record count * Performance improvements for table record counting * Add release notes * Added missing sub * Implement auto-recover functionality [B: 1403] (ctrlo#483) * Rebulid JS and CSS * Refactored code and added await to stop race conditions (ctrlo#507) * Rebuild JS * Autosave fix (ctrlo#508) * Refactored code and added await to stop race conditions * Added relevant comments * Further updates to mitigate curval errors * Removed console.log * Removed console statement * Removed other console statements * Added and updated comments as appropriate * Removed unusual undef code * Rebuild JS * Made timeline async Rendering of timeline is now async in order to ensure requests don't lock up the system and navigation can still be performed away from the timeline * Fix for person fields not displaying list correctly * Fix for similar users on multiple tenants [B:1625] (ctrlo#515) * Fix for similar users on multiple tenants * Update fixing bug in not appending site_id to user validation query * Changes as requested * Updated fields to only change when necessary * Update variable name as jquery element and reuse * Moved x-frame-options header out of user_logged_in check Have also removed options that were present for IE compatibility as this is no longer required as we no longer support the browser. * Updated curval filter to not use custom typeahead for value * Fix uninit warnings * Add missing rollback * Webpack-changes (ctrlo#517) * Added ignores to watch * Added comments to webpack.config * Update webpack.config.js * Update webpack.config.js * Update webpack.config.js * Fix for panic due to milliseconds in deleted field * Added fix for timeout on autorecover [B:1361] (ctrlo#513) * Added fix for timeout on autorecover - Added a record identifier to the session - Removed clear from the save button code (we want the data cleared on successful submission) - Created a new Alert component that checks for the data attribute that contains the record ID, and clears the data using that if it's present - Added data attribute to the message_center view * Various changes - still WIP - Removed the `alert` component - Moved the session variable for the updated record into a new variable to - promote extensibility - enable other actions to be added as required for other purposes in future - Promote extensible handlers - Added a JS handler implementation * Implemented new storage provider * Added clear to save draft * Updated code as suggested Also added unit tests for clearAutoRecover and renamed file appropriately * Added file missed on previous commit * Fix unnecessary find * Updated code to ensure indexing on values when they are in return value fields is correct [B: 1765] (ctrlo#522) * Updated code to ensure indexing on values when they are in return value fields is correct * Updated code to avoid repetition. * Updated indentation to match current standards * Ensured error only shows once when encryption is disabled * Fix chronology curvals showing incorrectly [B:1783] * Rebuild JS * Fix failing tests * Updates to Changelist (ctrlo#511) * Rebuild JS * Fix for `setFieldValues` possibly erroring [B:1797] (ctrlo#530) * Rebuild JS * Fix download menu not displayed [B:1798] (ctrlo#532) * Removed count parameter from download options * Found other options in the menu affected by the flag * Update changelist * Fix email users modal not working (B1803) * Update changelog * Fix panics using deleted people in calcs This fix parses the requisite datetime as a value from the database rather than a (changing) CLDR format. It has also required removing the standard :all import of MooX::Types::MooseLike::Base as this was importing "Enum" which was conflicting with the use of the GADS::Column::Enum class. It also required the consistent use of GADS::DateTime has a role. * Update changelog * Fix for value-lookup component not being able to continue when erroring * Rolled back error causing filter typeaheads not to render correctly * Updated code to center progress div * Update changelist * Update changelist * Updated tests to check for relevant options [B:1798 addendum] (ctrlo#533) * Adds custom Cypress commands Adds three new custom Cypress commands to enhance testing capabilities: - `setAllTablePermissions`: Automates the process of navigating to the table permissions page and checking all unchecked permission boxes. - `addUserToGroup`: Simplifies the process of adding a user to a specified group by navigating to the user overview, selecting the user, and checking the corresponding group checkbox. * Adds data view tests for admin user Adds end-to-end tests using Cypress to verify the presence and correctness of data table elements; including tabs, navigation items, and dropdown menus, specifically for the admin user role. This ensures that the intended user interface components are rendered and function as expected for administrative users, maintaining the integrity of the data view functionality. * Added loading div to timeline * Update changelist * Fix basic authentication in API (B:1832) * Updated code to make GET requests where data is exchanged to use POST [B:1533, 1763] (ctrlo#548) * Updated code to make GET requests where data is exchanged to use POST * Removed extra conversion from URL parameters where it wasn't needed * Removed unnecessary code from files as suggested where required * Removed GET from request * Amended to allow for request that was missed previously [B:1533] (ctrlo#553) * Updated code to make GET requests where data is exchanged to use POST * Removed extra conversion from URL parameters where it wasn't needed * Removed unnecessary code from files as suggested where required * Removed GET from request * Removed deprecation * Updated to post request Also removed previous changes as these were causing the requests to hang * Modified application to allow file uploads to save to server filesystem [B:1768] (ctrlo#540) * File uploads complete - unit tests require refactoring * Changes to file uploads to use filesystem * Adds configuration initialization to tests Ensures consistent test execution by initializing the configuration with the uploads directory for all test files as required. * Updated file command to unlink files * Fixed error in code and forced check for file before unlinking * Updated code for file deletion from disk * Changes as suggested in review There are still some larger changes to complete, these will follow in another commit * Modified sub to use passed in parameters rather than options hash * Modified tests as suggested and added required file to workflow * Fix typo in code * Added paging to * Fixes as suggested - Also removed .gitigore file that wasn't required * Further changes to spacing and indentation * Further changes as suggested in review * Updates to config in test and fixed hash not being passed correctly * Changes to allow cypress tests to pass * Fixed bugs in migration script * Fixes for Webdriver and Cypress tests * Update to version of Ubuntu on Webdriver test * Permission modification on migration * Added comments * Updated permissions to set on directory creation when migrating * Fixed typo * Further changes due to scalar dereferencing being odd * Different way of handling permissions and ownership * Forgot leading 0 on permissions * Update Config.pm * Updated logreport usage * Fixed permissions where file download wasn't possible * Updated file permissions to 664 * Reset default uploads directory * Updated migration to take environment variable into account * Changes to allow for multiple file uploads via drag and drop [B: 1799] (ctrlo#552) * Added support for multiple uploads * Additional changes missed in previous commit * Added error handling and some type checks * Fixed bug in logging * Better handling of multiple file uploads in fileInput * Modified error display * Updated handler to not use d-flex as this overrides visibility * Removed erroneous isString, and removed changes to logging that should be in seperate commit * Enhances file upload flexibility [B1836] (ctrlo#550) * Added option to upload custom file types and mime types Also added CLI script to add mime types and extensions at the layout level * Formatting * Removed changes in files in favour of alternative implementation * Removed not required migration * Restore file accidentally deleted * Rolled back further changes * Updated to new implementation Implementation doesn't store the mimetypes in a data attribute. It uses the layout id to find the relevant column, and then uses properties on that column (rather than relying on a schema update). * Removed extra changes * Updated file check where empty settings were allowing all files * Fixed error in Filecheck * Removed file check from validate * Updated add-extension * Removed debug logging * Fix for failing unit test * Update File.pm * Update Filecheck.pm * Updates to code as suggested * Changes as suggested * Updated documentComponent removing merge conflicts and removing unnecessary code * Update add-extension.pl to remove extra newline statements * Update add-extension.pl to remove `say` * Updated component and controller code [B:1767] (ctrlo#546) * Updated to include error message if present on timeout for selects * Added comment to code to clarify if statement * Added edge-case to use post as required * Removed erroneous changes * Revert of file as this was in the incorrect PR * Revert of file as this was in the incorrect PR - found further changes * Revert of file as this was in the incorrect PR - found further changes * Formatting * Updated for better error message parsing * Added further message parsing * Removed unnecessary parsers Data was being correctly returned as JSON rather than string, so marshalling of data is not required. This functionality has been removed. * Removed extra code and reverted errors in code * Fix failing test * Fix graph grouping of datetime fields such as edited time * Fix submission of graph date ranges * Fix y-axis group by option list * Fixes for file uploads (ctrlo#556) * Updated file column to remove erroneous line * Updated to allow for undef when creating field * Updated filecheck for undef values * Updated options to allow for read-only options and updated filecheck * Removed debug statement * Updated add-extension script, and upload control * Added changes to files * Updated file check * Updated filecheck * Updated user configurable hash to more sensible values * Updated to remove file name check * Fixed failing Jest test * Updated for use of \Q and \E in regex * Updated filecheck to use actual files * Removed and modified comments * Re-added size check to upload check, and comments to check_name * Further changes to methods to better support filevals and uploads * Fix for typo in Fileval file * Fixed incorrect sub name in call * Updated errorhandler * Further error checks * Revert "Further error checks" This reverts commit 22ad5eb. * Revert "Updated errorhandler" This reverts commit cd95359. * Update File.pm * Updated rename button to fix where it wasn't working on fields with existing values [B:1886] (ctrlo#557) * Updated file column to remove erroneous line * Updated to allow for undef when creating field * Updated filecheck for undef values * Updated rename button to fix where it wasn't working on fields with existing values * Updated options to allow for read-only options and updated filecheck * Removed debug statement * Updated add-extension script, and upload control * Added changes to files * Updated file check * Updated filecheck * Updated user configurable hash to more sensible values * Added better progress handling for multiple files * Revert "Added better progress handling for multiple files" This reverts commit c7a3220. * Updated to remove file name check * Fixed failing Jest test * Updated for use of \Q and \E in regex * Updated filecheck to use actual files * Removed and modified comments * Re-added size check to upload check, and comments to check_name * Further changes to methods to better support filevals and uploads * Fix for typo in Fileval file * Fixed incorrect sub name in call * Updated errorhandler * Further error checks * Revert "Further error checks" This reverts commit 22ad5eb. * Revert "Updated errorhandler" This reverts commit cd95359. * Reverted items showing as changes where not required * Update to allow for multiple progress bars for uploads [B:1877] (ctrlo#558) * Updated file column to remove erroneous line * Updated to allow for undef when creating field * Updated filecheck for undef values * Updated rename button to fix where it wasn't working on fields with existing values * Updated options to allow for read-only options and updated filecheck * Removed debug statement * Updated add-extension script, and upload control * Added changes to files * Updated file check * Updated filecheck * Updated user configurable hash to more sensible values * Added better progress handling for multiple files * Revert "Added better progress handling for multiple files" This reverts commit c7a3220. * Updated progress bars * Updated to allow for multiple progress bars * Updated error display * Updated to remove file name check * Fixed failing Jest test * Updated for use of \Q and \E in regex * Updated filecheck to use actual files * Removed and modified comments * Re-added size check to upload check, and comments to check_name * Further changes to methods to better support filevals and uploads * Fix for typo in Fileval file * Added fix for disappearing progress bars * Fixed incorrect sub name in call * Updated errorhandler * Further error checks * Revert "Further error checks" This reverts commit 22ad5eb. * Revert "Updated errorhandler" This reverts commit cd95359. * Fixed error handling * Reverted items showing as changes where not required * Updated Changelist * Fix for rename not erroring correctly * Rebuild JS and CSS * Fix editing of curvals within form This fixes creation of new curvals, editing of original curvals and editing of newly-created curvals. The ID has been removed from the hidden data, which was never actually used and would otherwise be attempted to convert into form data. * Rebuild JS * Update changelog * Fix curval values being incorrect removed on save * Rebuild JS * Update changelog * Fix error adding new curvals * Rebuild JS * Updated `match` endpoint to post and updated typeaheads and other code as appropriate (ctrlo#572) * Rebuild JS * Update changelog * Revert "Fix blanking of values user does not have access to" [B:1747] (ctrlo#576) This change is being reverted as it was allowing users who do not have access to fields to enable them to be blanked. * Close modal on cancel A fix to close the password reset modal on cancel. * Add initial hooks functionality * Fixes to allow tests to run within containers [B:1852] (ctrlo#563) * Updated filters to not show on blank filter * Stop automatic replies to emails * Remove auto-generated pod for schema files This commit removes all the pod for the DBIC schema files that was mainly auto-generated. The pod is out of date, inconsistent and not of great value. Pod will potentially be added back in the future once it has been deemed what is useful. * Better value if invalid curval IDs on retrieval * Performance - link latest record version (D1098) This commit improves performance by linking the current version of a record to its main stub, thereby making retrieval faster for records with lots of versions. The version retrieval functionality is retained for the purpose of historical view, which operates as it previously did. This commit also includes the addition of curval subfields to the y-axis of graphs (back-end only) which was needed to test some of the changes. It also includes sorting for grouping, which was needed for keeping the grouping tests working as before. * Add border and spacing to clarify where different text values end * Fix views made with whitespace-only names (D1060) (ctrlo#592) * Fix views made with whitespace-only names * Update error message to improve clarity --------- Co-authored-by: Pawel <p.wlodarski@ctrlo.com> * Incorporate feedback from code review * Complete default report setup (D 800) (ctrlo#580) * Complete default report setup Move PDF functionality to `GADS::PDFGenerator` class * Updated fat comma formatting as requested * Updated title for report * Updated to create alert rather than modal for auto-recover [D: 831] (ctrlo#579) * Fix for Auto-Recover being invasive - Add `Buildable` interface - Add the `Hidable` abstract class for hiding elements - Add the `ButtonBuilder` for building custom buttons - Add the `AlertBuilder` abstract class for creating alerts, as well as a number of specific Alert types that can be built using this class - Prevent alert showing when not on record pages - Prevent modal showing when other alerts have values - Reword values in alert and modal - Update modal to show fields being changed * Reword modal * Updated cypress tests * Updated to default to "all" view on view all button click (D795) * Fix syntax error from manual merge * Rebuild JS and CSS * Fix display condition bug (D797) (ctrlo#603) * Fix for regressive error in display conditions * Modify code to no longer remove erroneous conditions and instead create error * Remove change to typing * Version 2.8 * Rebuild JS * Bump JS version * Completed error logging to Audit (D990) (ctrlo#589) * Completed error logging to Audit Also add logging upload to logging JS * Update to use `Log::Report` * Change code as per review Also remove extrenous logging and debugging code that was added during development of this feature. * Fix erroring test * Return JSON as required * Restricts account permission views to admin only Stops any non admin shared views from being displayed in the list of available options when applying the user view limits. * Rebuild JS * Fix record download when approval records exist (D:1350) * Merge pull request ctrlo#594 from pwlodarski-ctrlo/empty-import-heading-patch Added appropriate error for blank field name heading in record imports (D1099) * Update cache to ignore values over 250 characters (D1118) (ctrlo#596) * Update cache to ignore values over 250 characters * Fix cache code - Fix incorrect return on calc cache code - Add unit test to ensure correct write operation * Fix test for caching and added search test * Update test to check for value removal * Added comment to test and removed debug code * Remove logging line which was causing an error * Updated changelist * Fix incorrect IDs shown for curcommon errors * Better error when duplicate curval IDs are requested * Initial multi-factor auth functionality (#1521) Still requires: * Front-end configuration of user's MFA and site-wide policy * Ability for an admin to reset a user's MFA (use reset_mfa()) * Fix failing tests * Fix failing tests * Fix cookie secure configuration * Javascript logging fix (D:1512) Squashed from PR by droberts-ctrlo Fix error in logging.js where the message variable is re-declared in the else block of the logging code, causing the code to error when calling outside of a debug environment rather than undergoing the expected behaviour. NB Unit test was removed due to adding excess complexity to the code - will re-evaluate and look at possible fix * Update changelist and version number * Rebuild JS * Update webpack file to silence deprecations we have no control over * Require access to current record for historical (#860) * Show curval specific edited information in parent chronology (#857) * Move dispatch.cgi to bin directory [D:1119] * Move dispatch.fcgi to the bin directory [D: 1119] * Fix cypress to work with newer browser versions * Add wording for file uploads and update templates (D1092) (ctrlo#638) * Add wording for file uploads and update templates * Add character limit to text fields (D1559) (ctrlo#623) * Fix infinite redirect if password expired * Fix user being asked to enter MFA expectantly whilst logged-in * Merge pull request ctrlo#640 from droberts-ctrlo/deb13-changes Trixie unit tests (maintenance) * Reduce MFA cookie to 2 days from 7 days Because the MFA cookie is now renewed every page render, it is possible that a user only using the system weekly will never need to authenticate with MFA. Reduce the time to 2 days to ensure weekly MFA if not logging in at the weekend. * Date range fix (D1170) * Add asterisk in CSS * Remove extra asterisk * Add danger color to invalid date-range label * Add override view option to see restricted records (#814) * Add details on who created a user (#1178) * Add date and time format to calc fields (#943) * Add target version for DB migration script * Fix update of user value in create user * Fix missing HTML encoding for user drop-down label * Fix failing test * dev-bootstrap rebase from dev (ctrlo#654) --------- * Add checks for deprecation and apply fixes where possible * Add correct data-bs-* attributes where they were missed * Added editorconfig and upgraded ESLint to current version * Added JSDocs (squashed from DR) * Added searchable select component Removed bootstrap select Bootstrap select is no longer compatible with Bootstrap v5 - the version that is compatible is still in beta and contains bugs that make it unsuitable for our use-case Updated code to fix WCAG issue Updated changes as per ticket Updated datatables for more consistent colours Fix for fullscreen switch not working as expected Modified header for correct placement of pills in dashboard * Clean up code * Created and updated JSDoc and TS typings where necessary * Fix autosave colour issue * Fix cypress to work with newer browser versions * Fix datatable alignment * Fix datatables responsive rendering * Fixed bug in tables setup where definition was incorrect for table_layout * Fixed error in more-less * Fixed formatting and code where this was broken on merge with current dev branch Updated and removed extra dependencies and exports where not required Further package changes and TSConfig updates Removed knip * Fix error in datatables SCSS causing screen to blank when no layout is present * Fix invalid font-weight on edit button * Fix invalid header on field selection * Fix JS after package upgrade * Fix or mitigate errors in tests where possible * Fix test to only skip erroring sections rather than the whole test * Fix where review highlighted errors or invalid changes * Formatted and changed code with ESLint fixes - functionality has not changed Removed cjs from eslint - cjs are used for internal development files, and should never be included * Formatted test and config code and updated test files Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build. * Move back to double quotes Don't know why I felt that JS/TS should only use single quotes, and it just adds more changes to the tree for what seems like an arbitrary reason. So moving back to double quotes. * Package upgrades * Remove bootstrap-icons * Removed extra packages * Removed extra unused dependencies * Removed invalid import where required * Removed npx call in tests after failure Updated file where missing function wasn't included * Remove invalid branch from tests.yml * Remove unnecessary Cypress changes * Update action to use current node version * Update autosave.test.ts * Update browsers list db * Update code and tsconfig to omit errors * Update component.js * Update correct API usage in Markdown formatter * Update cypress to fix failing tests * Updated and removed extra dependencies and exports where not required Further package changes and TSConfig updates Removed knip * Updated code to align with BS5 * Updated dashboard and react components * Update dependencies and modify tests * Updated error handler * Updated filter where typeahead is missed * Updated layoutbuilder to ensure cypress tests pass * Updated linting rules, and added comments where required Updated documentation Fixed formatting and code where this was broken on merge with current dev branch Added fix for error on documentComponent Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included * Updated package.json to remove extra dependencies * Updated packages where required * Updated to new DataTables.net API Updated to use new switch component for fullscreen * Updated ts-ignore where this was causing issues with linting and checking correctness * Updated with changes within current dev * Update files as per review * Update file where review item was missed * Update libraries to latest minor version * Update libraries to latest revision * Update lists to provide gap between * Update minor versions * Update package.json * Update tests to run async calls as shown in documentation Also update assertions in test to ensure correct calls are being made * Update tests.yml * Update view to encode title correctly * Update webpack file to silence deprecations we have no control over * Upgraded packages and set up new webpack config * Upgrade packages * Use variables where possible rather than hex colours * Fix validation error where field length was not set (v2.9 bugfix) (ctrlo#655) * Update views to omit length check where it wasn't set * Update to allow for zero length and to test said case * Script to import and export layout group permissions in bulk [D: 1825] * Added script for bulk import/export of layout group permissions This script allows bulk importing and exporting group layout permissions. * Merge pull request ctrlo#645 from droberts-ctrlo/view-type-toggle Change view type to a select so that only one type is selectable (D888) * Do not allow access to chronology if no current access (#860) * Basic lib definitions - initial set * Update source files * Add TS6, update tsconfig, and update code where required * Fix missed change * Fix where `seed-database.pl` was causing an error * Fix historical view when no curval existing (#2088) This commit fixes historical viewing not working when a record has a curval field but that curval field does not have any values. In this case its version date would be null, which was not included in the search and therefore the record data was not retrieved correctly. * Added types * Fix for component missed in dev branch when upgrading * Update to fix where max_length.size was not returning expected value (ctrlo#669) * Update to fix where max_length.size was not returning expected value * Update as per review --------- Co-authored-by: Andy Beverley <andy@andybev.com> Co-authored-by: Oliver-ctrlo <119069310+Oliver-ctrlo@users.noreply.github.com> Co-authored-by: Pawel <p.wlodarski@ctrlo.com> Co-authored-by: pawelw <pawelwlod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.