Skip to content

Conversation

@davidjgoss
Copy link
Contributor

🤔 What's changed?

When developing locally, screenshot tests are now run on the same Docker image as used in CI.

⚡️ What's your motivation?

We had a tolerance (via maxPixelDiffRatio) to account for platform differences with typography etc, but it could and did disguise genuine differences - now we can run without that.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review November 13, 2025 10:26
@davidjgoss davidjgoss merged commit ad61940 into main Nov 13, 2025
23 checks passed
@davidjgoss davidjgoss deleted the screenshot-tests-accuracy branch November 13, 2025 10:37
davidjgoss added a commit that referenced this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant