Feature/dsm 169 - reorganize rails routes#70
Merged
Conversation
wtomaszewska
reviewed
Jun 2, 2026
| <% # The sign out route uses a DELETE method to prevent CSRF attacks. %> | ||
| <p> | ||
| <%= form_with(url: destroy_user_session_path, method: "delete") do |form| %> | ||
| <%= form.submit "Sign out" %> |
There was a problem hiding this comment.
Would be nice to have this element use Bootstrap to match the rest of the app, for example:
Suggested change
| <%= form.submit "Sign out" %> | |
| <%= form.submit "Sign out", class: "btn btn-light btn-sm" %> |
wtomaszewska
reviewed
Jun 2, 2026
|
|
||
| <%= yield :head %> | ||
| </head> | ||
| <nav class="d-flex py-2 px-5 bg-primary bg-opacity-25 justify-content-end"> |
There was a problem hiding this comment.
I don't think this is valid HTML (nav has to be a child of body), but somehow the DOM renders it correctly as 'body > nav'.
Author
There was a problem hiding this comment.
I was curious and did some googling, and it seems the browser is inferring where it belongs -- apparently some tags are technically optional and browsers can infer where content goes in the DOM! Didn't know that was a thing
I'll move it inside body regardless
wtomaszewska
approved these changes
Jun 2, 2026
wtomaszewska
left a comment
wtomaszewska
left a comment
There was a problem hiding this comment.
Looks great! Left just a minor suggestion if we want to use Rails to render UI elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This branch renders the React SPA root element (and application) at the root route of the rails application.
If a user is unauthenticated, they are immediately redirected to the sign in view.
To enable people to sign out of the app, I also added a bar at the top of the s3 app layout with the sign out link button.
And to make sure any error toasts don't overlap the sign out button, I adjusted the style of the Notifications component.