Skip to content

fix: revert igniter dep to optional#58

Merged
vincentvanbush merged 3 commits into
mainfrom
patch/revert-igniter-to-optional
May 25, 2026
Merged

fix: revert igniter dep to optional#58
vincentvanbush merged 3 commits into
mainfrom
patch/revert-igniter-to-optional

Conversation

@vincentvanbush
Copy link
Copy Markdown
Contributor

Pull Request

See curiosum-dev/permit#63.

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test improvements
  • CI/CD improvements

Related Issues

Fixes #
Closes #
Related to #

Changes Made

Testing

Test Environment

  • Elixir version:
  • OTP version:
  • Phoenix version:
  • LiveView version:
  • Database (if applicable):

Test Cases

  • All existing tests pass
  • New tests added for new functionality at appropriate levels
  • Manual testing performed
  • Controller integration tests (if applicable)
  • LiveView integration tests (if applicable)
  • Router integration tests (if applicable)

Test Commands Run

# List the commands you ran to test
mix test
MIX_ENV=test mix credo
MIX_ENV=test mix dialyzer

Documentation

  • Updated README.md (if applicable)
  • Updated documentation comments (with examples for new features)
  • Updated CHANGELOG.md (if applicable)
  • Updated controller/LiveView usage examples (if applicable)

Code Quality

  • Code follows the existing style conventions
  • Self-review of the code has been performed
  • Code has been commented, particularly in hard-to-understand areas
  • No new linting warnings introduced
  • No new Dialyzer warnings introduced
  • Follows Phoenix and LiveView conventions

Phoenix/LiveView Specific

  • Controller changes properly handle conn state
  • LiveView changes properly handle socket state
  • Router integration works correctly
  • Error handling follows Phoenix patterns
  • Authorization flows work as expected

Backward Compatibility

  • This change is backward compatible
  • This change includes breaking changes (please describe below)
  • Migration guide provided for breaking changes

Breaking Changes

Performance Impact

  • No performance impact
  • Performance improvement
  • Potential performance regression (please describe)

Performance Notes

Security Considerations

  • No security impact
  • Security improvement
  • Potential security impact (please describe)

Additional Notes

Screenshots/Examples

# Example usage of new feature
defmodule MyAppWeb.ArticleController do
  use Permit.Phoenix.Controller,
    authorization_module: MyApp.Authorization,
    resource_module: MyApp.Article

  # New functionality here
end

Checklist

  • I have read the Contributing Guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Reviewer Notes


@vincentvanbush vincentvanbush merged commit 5bdc592 into main May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant