fix(etoro-trading): declare server placement for Grok Bot - #461
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
eToro Trading (
third_party/etoro-trading, added in #410) installs in Grok Bot but never shows a connect / sign-in card, so users cannot reach eToro's hosted MCP athttps://mcp.public-api.etoro.comfrom Settings → Connectors.Cause: Grok Bot dials only SERVER-placed hosted MCP rows.
etoro-trading/mcp.jsonhas noplacementfield, so its row stays UNDECIDED. This is the same gap #438 fixed for TinyFish, beehiiv, Trello, Buffer and Plaud.Fix: add
"placement": "server"to theetoro-tradingserver entry, bump the plugin to 1.0.1 so clients re-fetch the manifest, and add a CHANGELOG line. eToro's own developer plugin (etoro, the API docs listing) is untouched.Verified
node scripts/validate-plugins.mjspasses for all plugins.third_party/x-money/mcp.jsonand the third_party: declare server placement for TinyFish, beehiiv, Trello, Buffer, Plaud #438 plugins.https://www.cursor.com/agents/mcp/oauth/callback+http://localhost:8787/callback), probed 2026-09-29.Follow-ups
etoro-tradingfrom public-draft to public-listed.https://www.cursor.com/bot/mcp/oauth/callbackandgrokbot://mcp/oauth/callbackon/api/sso/v1/register(currently 400invalid_redirect_uri); requested from eToro separately.Note
Low Risk
Manifest-only change (MCP placement + version bump); no runtime or auth logic modified.
Overview
Fixes Grok Bot so the eToro Trading connector can show a connect / sign-in card instead of staying in an undecided state.
Adds
"placement": "server"to the hosted HTTP MCP entry inmcp.json(same pattern as other third-party hosted MCP plugins). Bumps the plugin to 1.0.1 and documents the change in CHANGELOG so clients pick up the updated manifest.Reviewed by Cursor Bugbot for commit 0b38ff6. Bugbot is set up for automated code reviews on this repo. Configure here.