feat: sync theme variables with figma #1696
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| export const Spacing = { | ||
| '50': '0', | ||
| '75': '0.0625rem', // 1px |
Collaborator
There was a problem hiding this comment.
this can be breaking due to this usage
this means now everywhere where we use spacing, gap, padding, margin etc with integers will become smaller.
Contributor
Author
There was a problem hiding this comment.
You mean that we shouldn't add 75?
Collaborator
There was a problem hiding this comment.
We could but then maybe we can hardcode the other ones in the spacing var passed to the theme
Collaborator
There was a problem hiding this comment.
So that line should become
spacing: range(8).map(i => Spacing[i*100]), | '600': '2rem' /* 32px */, | ||
| '700': '3rem' /* 48px */, | ||
| '800': '4rem' /* 64px */, | ||
| '50': '0', |
Collaborator
There was a problem hiding this comment.
I wonder why not use 0 here
Suggested change
| '50': '0', | |
| '0': '0', |
OnlyJousting
force-pushed
the
feat/sync-theme-variables-with-figma
branch
from
1acc60f to
6c1cdb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates theme variables from exported figma variables json