fix: Transform within default variables#88
Open
NikolayMakhonin wants to merge 1 commit intocuth:masterfrom
Open
fix: Transform within default variables#88NikolayMakhonin wants to merge 1 commit intocuth:masterfrom
NikolayMakhonin wants to merge 1 commit intocuth:masterfrom
Conversation
|
@NikolayMakhonin Already handled this in #80. Nonetheless, your regex seems less constrained. I would only suggest to write a test for that case. |
|
Anyway, I think this library might need a reliable fork, as @cuth seem not to maintain it for some time |
|
There’s one by @hemengke1997 at https://github.com/hemengke1997/postcss-pxtorem, and we’re at an early stage of using it at work, but so far it’s great. |
|
@yangmingshan @cuth Please add the ability to convert px to em inside var in the callback ignoring custom variables. Can u merge and release a new version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transform within default variables
#79