Skip to content

Practice code review with coding partner#1

Open
cwaku wants to merge 2 commits intomainfrom
review-test
Open

Practice code review with coding partner#1
cwaku wants to merge 2 commits intomainfrom
review-test

Conversation

@cwaku
Copy link
Copy Markdown
Owner

@cwaku cwaku commented Dec 7, 2021

All projects requirements are met. Please do review my code if you have time

@tongoonamujera
Copy link
Copy Markdown
Collaborator

tongoonamujera commented Dec 7, 2021

  • Nice to have a working codebase
  • Nice to have a dry code
  • It will be more nice to move your todo list logic to seperate files from index.js
  • Its nice to add some methods into seperate files with which you can call these class methods inside your index.js

@cwaku cwaku requested a review from tongoonamujera December 7, 2021 14:14
@tongoonamujera
Copy link
Copy Markdown
Collaborator

tongoonamujera commented Dec 7, 2021

great work man

@cwaku
Copy link
Copy Markdown
Owner Author

cwaku commented Dec 8, 2021

great work man

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants