chore: revert "dependency: update mime from 3.0.0 to 4.1.0" #32975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
approved these changes
Nov 19, 2025
This reverts commit a267d31.
AtofStryker
force-pushed
the
revert-32936-issue-30144-mime-to-4.x
branch
from
5c5904f to
e4b0960
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| expect($input.files?.[1].name).to.eq('app.js') | ||
| expect($input.files?.[0].type).to.eq('application/json') | ||
| expect($input.files?.[1].type).to.eq('text/javascript') | ||
| expect($input.files?.[1].type).to.eq('application/javascript') |
There was a problem hiding this comment.
Bug: Test expects wrong MIME type after reverting mime
The test expects application/javascript as the MIME type for .js files, but after reverting the mime package from version 4.1.0 back to 3.0.0, the package will return text/javascript instead. The original test before the mime upgrade expected text/javascript, confirming that mime 3.0.0 returns this value. This test expectation was changed to match mime 4.x behavior but wasn't reverted along with the dependency downgrade, causing the test to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #32936. see #32936 (comment)
Note
Reverts mime to v3 across packages, adds @types/mime v3 types, updates a test to expect application/javascript, and cleans up changelog/lockfile.
mimeto^3.0.0inpackages/driver,packages/server, andpackages/net-stubbing.@types/mime@^3.0.1inpackages/driver,packages/server, andpackages/net-stubbing.yarn.lockto reflectmime@^3and new@types/mimeentries..jsfiles inpackages/driver/cypress/e2e/commands/actions/selectFile.cy.tstoapplication/javascript.mimewas upgraded to4.1.0incli/CHANGELOG.md.Written by Cursor Bugbot for commit e4b0960. This will update automatically on new commits. Configure here.