Skip to content

Add MultiViewLightGBM model#430

Open
tereshchuk1 wants to merge 4 commits into
daisybio:developmentfrom
tereshchuk1:add-lightgbm
Open

Add MultiViewLightGBM model#430
tereshchuk1 wants to merge 4 commits into
daisybio:developmentfrom
tereshchuk1:add-lightgbm

Conversation

@tereshchuk1

Copy link
Copy Markdown
Contributor

Description

Add MultiViewLightGBM model. Supports gene expression, methylation, mutations, copy number variation, and proteomics and drug fingerprints

Changes

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!

New features

  • Added MultiViewLightGBM model
  • Registered model in drevalpy/models/__init__.py
  • Added hyperparameters to hyperparameters.yaml
  • Added lightgbm as optional dependency in pyproject.toml
  • Added lightgbm to nox test session extras in noxfile.py
  • Added MultiViewLightGBM to baseline tests

@tereshchuk1 tereshchuk1 force-pushed the add-lightgbm branch 2 times, most recently from df5be1f to 61e15af Compare June 12, 2026 04:10
@codecov-commenter

codecov-commenter commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 87.50000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.92%. Comparing base (7d24cd6) to head (89f0cab).
⚠️ Report is 13 commits behind head on development.

Files with missing lines Patch % Lines
drevalpy/models/baselines/multi_view_lightgbm.py 87.00% 13 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #430      +/-   ##
===============================================
+ Coverage        80.34%   80.92%   +0.58%     
===============================================
  Files              101      103       +2     
  Lines             8171     8336     +165     
===============================================
+ Hits              6565     6746     +181     
+ Misses            1606     1590      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread drevalpy/models/baselines/hyperparameters.yaml Outdated
Comment thread pyproject.toml Outdated
@tereshchuk1 tereshchuk1 changed the title Add MultiViewLightGBM model and include lightgbm in nox test session Add MultiViewLightGBM model Jun 14, 2026
@PascalIversen

Copy link
Copy Markdown
Collaborator

Thanks! Could you also run the model and add it to the leaderboard?

Comment thread pyproject.toml Outdated
@JudithBernett

Copy link
Copy Markdown
Contributor

Thanks! Could you also run the model and add it to the leaderboard?

@PascalIversen If we merge it in, I can also do it :) I already have the splits used for the leaderboard, then it would be fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants