Conversation
Resolve conflict in client_test.cc, keeping both the free function CreatePublisher/CreateSubscriber tests from main and the PluginTest heartbeat fixture from this branch. Made-with: Cursor
…in README Made-with: Cursor
…into shutdown_race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a race with shutdown of the server. Plugins that create a publisher (or subscriber) need to delete them when they shut down. However, the server will stop the listener coroutine at some point and this may prevent the client from connecting to the server to delete the publisher or subscriber. The fix is to prevent the shutdown of the listener coroutine until all other coroutines have stopped.