Feature/adding better support for php 8.2 #65
Conversation
…erties in test classes.
| "autoload" : { | ||
| "psr-4": { | ||
| "Collections\\": "src/" | ||
| } |
There was a problem hiding this comment.
Since you add return types, you should also update the part of the composer.json file where the PHP version is defined, because you drop the support for PHP 5.x which is also mentionned in the README.md :)
There was a problem hiding this comment.
Sure thing, thanks for the review :)
There was a problem hiding this comment.
Hi, Eric. I have updated the PR, dropping the support for php 5.x. Now, the minimum is 7.x, while the latest version of php and dev requirement libs are also supported for the most up-to-date users. Please let me know if there's something else I can do. Thanks again.
There was a problem hiding this comment.
@danielgsims is your package stil maintained :) ?
There was a problem hiding this comment.
Since it is not marked as abandoned, can we consider merging the PR regardlessly?
There was a problem hiding this comment.
Well I am not a maintainer of this repo, so... :/
renaming package
|
@danielgsims @zkucekovic @ecourtial since I saw no more feedback from Daniel, I believe this package is abandoned? I took the liberty to create my own based on Daniel's idea. You guys feel free to use and of course contribute. |
4 participants
No description provided.