refactor(hooks): remove dead TheRouter-era exports (markSessionNative, markAlgorithmStarting, setModeToken)#1599
Open
anikinsasha wants to merge 1 commit into
Conversation
…, markAlgorithmStarting, setModeToken)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the three exports orphaned by the 7.0.0 retirement of TheRouter.hook.ts (
3baba670) — zero callers, imports, tests, or dynamic references onmain. Full diagnosis and grep evidence in #1598 (this PR is the mechanical half; the downgrade-guard behavior question stays in the issue).hooks/lib/isa-utils.ts: delete 1252-1400 — the orphanedmarkAlgorithmStartingdocblock (1252-1269, physically detached above the wrong function),markSessionNativedoc+fn (1270-1315),markAlgorithmStartingfn (1317-1400). TheupsertNativeSessionalias (1249-1250) and everything fromaddRatingPulse(1402+) untouched.hooks/lib/tab-setter.ts: delete 343-393 —setModeTokenJSDoc+fn andLIVE_ALGO_PHASES(362), which only it referenced.Deletion-only; no behavior change. Deliberately does not touch:
isDowngradeFromAlgorithmguard (live — its fate is the open question in TheRouter remnants: three dead exports, and the algorithm→native downgrade block is now unconditional #1598);extractModeToken/MODE_TOKEN_RE/ PromptProcessing's recovery branch (live E-badge machinery — see TheRouter remnants: three dead exports, and the algorithm→native downgrade block is now unconditional #1598);isa-utils.ts:1181-1183that still names the deleted function — those ride a separate wording-sweep PR (in preparation) so the hunks don't overlap.Testing:
bun build LifeOS/install/hooks/lib/isa-utils.ts LifeOS/install/hooks/lib/tab-setter.ts LifeOS/install/hooks/PromptProcessing.hook.ts --target=bungreen on this branch (afterbun installinLifeOS/install); post-deletegit grepfor the three symbols returns only historical doc mentions plus the one guard-comment line noted above.