remove confusing deep_merge #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
rebased |
jrafanie
reviewed
Nov 20, 2024
| def deeper_merge(source, options = {}) | ||
| default_opts = {:preserve_unmergeables => true} | ||
| DeepMerge::deep_merge!(source, self, default_opts.merge(options)) | ||
| end |
Contributor
There was a problem hiding this comment.
I agree with the idea of this PR. Although, we should probably deprecate this first in a release, then drop it after.
Contributor
Author
There was a problem hiding this comment.
please make that PR then, not using this library anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergein ruby hash is defined as returning a copy that is merged whereasmerge!is in-placeso having a
deep_mergethat modifies in-place leads to confusion/bugssee #56
cc @Fryguy