Clean up MANIFEST.in

[DimitriPapadopoulos]

From Controlling files in the distribution:

For the most common use cases, setuptools will automatically find out which files are necessary for distributing the package. More precisely, the following files are included in a source distribution by default:

• All files specified by the license-files configuration parameter in pyproject.toml [...]; note that if you don’t explicitly set this parameter, setuptools will include any files that match the following glob patterns: LICEN[CS]E*, COPYING*, NOTICE*, AUTHORS**;
• pyproject.toml;
• setup.py;
• README, README.txt, README.rst or README.md;
• MANIFEST.in

Source distributions should include tests:

distributed/MANIFEST.in

Line 12 in c7d9c55

recursive-exclude distributed **/tests/*

See Provide complete source distributions in the Python Packaging User Guide:

Ideally, a source distribution archive published on PyPI should include all the files from the package’s Git repository that are necessary to build the package itself, run its test suite, build and install its documentation, and any other files that may be useful to end users, such as shell completions, editor support files, and so on.

[github-actions]

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 52m 40s ⏱️ - 3m 48s
 4 112 tests ±0   4 007 ✅ +3    104 💤 ±0  1 ❌  - 3 
51 516 runs  ±0  49 330 ✅ +2  2 185 💤 +1  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit 1295c2f. ± Comparison against base commit 0771baa.

♻️ This comment has been updated with latest results.

[jacobtomlinson]

Looks good but has conflicts

[DimitriPapadopoulos]

Rebased.

[DimitriPapadopoulos]

Is it OK to remove this line?

distributed/MANIFEST.in

Line 12 in 3c651c6

recursive-exclude distributed **/tests/*

[jacobtomlinson]

Not sure, we dont want to ship tests

[DimitriPapadopoulos]

It is often (but not always) recommended shipping tests in sources distributions:

• Python Packaging User Guide

  With that being said, there are still important differences between sdists and wheels, even for pure Python projects. Wheels are meant to contain exactly what is to be installed, and nothing more. In particular, wheels should never include tests and documentation, while sdists commonly do.

• Setuptools documentation

  More precisely, the following files are included in a source distribution by default:
  [...]

  • Files that match the following glob patterns: tests/test*.py, test/test*.py;

• Should sdists include docs and tests?

It's not compulsory, of course.