Upgrade lucide-react to 1.x; expand smoke to cover all pages#89
Open
jamesbroadhead wants to merge 1 commit into
Open
Conversation
The v1 release deliberately removed all brand icons, including `Github`. Replace the two `<Github />` usages with a local SVG component that matches lucide's `size`/`className` interface, then bump `lucide-react` to ^1.14.0. Also extend the smoke test's render check from a hand-picked list of 4 pages to every static route the build emits (~90 pages today). The gallery `:id` template is skipped; concrete sample detail routes from the fallback list are still visited so the GalleryApp component stays covered. Co-authored-by: Isaac
Contributor
Author
|
@antonbricks — follow-up to #88. This is the second attempt at upgrading lucide-react to 1.x; the new local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-attempt of the v1 upgrade that PR #88 had to roll back. The blocker
was that
lucide-react@1deliberately dropped all brand icons, so theGithubnamed import resolved toundefinedand crashed/galleryand
/gallery/:slug.<Github />call-sites with a localdocs/src/components/GithubIcon.tsx— small SVG component matchinglucide's
size/classNameinterface, so the JSX site stays aone-liner.
lucide-reactto^1.14.0and regenerated the lockfile.BadgeCheck,ArrowLeft) are stillexported by v1; verified by the smoke audit step.
Smoke test coverage
The smoke test from #88 hard-coded a 4-page render list. Replaced it
with build-output discovery: every
build/<route>/index.htmlis nowvisited (~90 pages today). The
/gallery/:idtemplate route isskipped because it can't be visited directly, but the fallback list
keeps a concrete
/gallery/pixelsinstance in the run so theGalleryAppcomponent (the second<Github />call-site) staysexercised.
Locally:
npm run buildsucceeds.npm run smokewithCHROME_BIN=/usr/bin/google-chromepasses90 / 90 render checks and the lucide audit.
Test plan
cards show the GitHub icon next to "Source code".
load and the "View Source" button still shows the icon.
This pull request and its description were written by Claude (claude-opus-4-7) under the direction of @jamesbroadhead.