Run acceptance tests against a FIPS build in CI - #6193
Open
ilyakuz-db wants to merge 1 commit into
Open
Conversation
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 8b08765
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
ilyakuz-db
force-pushed
the
fips140-test-coverage
branch
from
August 10, 2026 10:12
4493134 to
8b08765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
test (linux, fips)CI job that builds the CLI withGOFIPS140=v1.0.0and runs the acceptance suite against it, plus a test that reads the built binary's build info to confirm it really was built with the validated module.No production code changes. The regular test jobs are untouched, and the new test skips unless
GOFIPS140is set.Why
Go selects its cryptographic module at build time via
GOFIPS140, so the module a binary uses is a property of the build rather than of the code. Every existing job builds without it, which means the FIPS module is never exercised: FIPS mode narrows the cipher suites the TLS client offers, so a passing suite today says nothing about whether the same code still works once the validated module is linked.The binary-inspection test exists because the job would otherwise still pass if
GOFIPS140stopped reaching the compiler — the suite would run against an ordinary build and report that FIPS works.Linux only: the module is platform-independent, so adding a second OS would spend wall-clock time re-testing the same crypto.
Tests
Locally,
GOFIPS140=v1.0.0 go test ./acceptance -run "^TestAccept$/bundle/resources"fails onlymodel_serving_endpoints/drift/recreated_same_name, which fails the same way withoutGOFIPS140(and on main) — so the FIPS build introduces no new failures.go version -mon the acceptance-built binary reports:The new test was checked in all three states: it skips on a default build, passes with
GOFIPS140=v1.0.0, and fails withGOFIPS140=latest(an unvalidated module version).This PR was written by Claude Code.