direct: honor ForceSendFields on the model_serving_endpoints remote - #6812
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 192b6e5
6 interesting tests: 3 FAIL, 3 flaky
Top 4 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/mse-fsf-root-prep
branch
from
September 29, 2026 10:48
a532a2a to
265226f
Compare
denik
changed the title
denik
force-pushed
the
denik/mse-fsf-root-prep
branch
from
September 29, 2026 12:17
265226f to
9e0b1ac
Compare
… root RemapState sourced ForceSendFields from the nested EndpointDetails, which the auto-copier (root ForceSendFields only) cannot reproduce. Surface it on the ModelServingEndpointRemote root in newModelServingEndpointRemote (filtered to the wrapper's own fields) and read it there in RemapState, making RemapState a plain subset copy. Add marshal-based MarshalJSON/UnmarshalJSON so the wrapper's extra fields survive the JSON state round-trip (mirrors VectorSearchEndpointRemote). Side effect: the plan remote_state now force-sends the surfaced fields, so the per-engine direct plan goldens are regenerated. No action/diff changes. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/mse-fsf-root-prep
branch
from
September 30, 2026 10:12
9e0b1ac to
192b6e5
Compare
denik
changed the title
denik
marked this pull request as ready for review
October 1, 2026 09:10
denik
enabled auto-merge
October 1, 2026 09:10
janniklasrose
approved these changes
Oct 1, 2026
denik
disabled auto-merge
October 1, 2026 10:08
denik
added a commit
that referenced
this pull request
Oct 1, 2026
#6812 surfaced ForceSendFields at the ModelServingEndpointRemote root, making its RemapState a plain copy. The auto-copier now reproduces it exactly (TestNoRedundantRemapState), so remove the method and let buildCopiers handle it. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface
ForceSendFieldsat theModelServingEndpointRemoteroot and marshal via the SDK'smarshalpackage, so the force-send convention is honored on the wrapper andRemapStatebecomes a plain subset copy — prep for the automatic copier (#6777). Only the per-engine*.direct.*plan goldens change; no action or diff changes.This pull request and its description were written by Isaac.