Warn when the CLI build is more than 6 months old - #6898
Open
shreyas-goenka wants to merge 8 commits into
Open
shreyas-goenka wants to merge 8 commits into
shreyas-goenka wants to merge 8 commits into
Conversation
Reads the build timestamp goreleaser embeds (shown in `databricks version -o json` as BuildTime) and prints a stderr warning recommending an update. Skipped for dev builds without a timestamp and on DBR, where the CLI ships with the image. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 4eb15a4
Top 6 slowest tests (at least 2 minutes):
|
Reuses versioncheck.DetectInstallMethod (brew/winget/choco/install script) and falls back to the install docs when the method is unknown. Dev and snapshot builds no longer warn. Co-authored-by: Isaac <no-reply@databricks.com>
The warning names the variable. Skip conditions move into skipStaleVersionWarning so tests can pass a release build; the old DBR test returned early on the test binary's dev version and never reached the DBR check. Co-authored-by: Isaac <no-reply@databricks.com>
…warning One opt-out for all upgrade nagging; exports versioncheck.DisableEnv. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified manually that this works: