Fix context loss in polling and connection close operations #295
+96
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diego Giagio <[email protected]>
dgiagio
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jadewang-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
This was referenced Nov 4, 2025
gopalldb
reviewed
Nov 24, 2025
| var statusResp *cli_service.TGetOperationStatusResp | ||
| ctx = driverctx.NewContextWithConnId(ctx, c.id) | ||
| newCtx := driverctx.NewContextWithCorrelationId(driverctx.NewContextWithConnId(context.Background(), c.id), corrId) | ||
| newCtx := context.WithoutCancel(ctx) |
Collaborator
There was a problem hiding this comment.
if context is cancelled, polling will not have cancellation information. Won't this affect cancellation of long running queries?
gopalldb
reviewed
Nov 24, 2025
| var statusResp *cli_service.TGetOperationStatusResp | ||
| ctx = driverctx.NewContextWithConnId(ctx, c.id) | ||
| newCtx := driverctx.NewContextWithCorrelationId(driverctx.NewContextWithConnId(context.Background(), c.id), corrId) | ||
| newCtx := context.WithoutCancel(ctx) |
Collaborator
There was a problem hiding this comment.
I see that context.WithoutCancel was added in Go 1.21, but go.mod pins to v1.20. This will fail.
Do we need a version change in go.mod as well?
gopalldb
reviewed
Nov 24, 2025
| config *config.Config, | ||
| directResults *cli_service.TSparkDirectResults, | ||
| ) (driver.Rows, dbsqlerr.DBError) { | ||
|
|
Collaborator
There was a problem hiding this comment.
do we need a check for context being nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the driver discards the
context.Contextduring polling, making it impossible to use authentication mechanisms (like Azure OBO) that rely on passing credentials via the context.Reference: