perf: fetch table tags through Unity Catalog API - #1603
Open
sd-db wants to merge 3 commits into
Open
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
…uards Reading table tags through the Unity Catalog API turned a Hive Metastore compiler error into a silent skip for views, so an HMS view configured with databricks_tags diffed against an empty tag set instead of failing. Raise for Hive Metastore in _get_table_tags, the single point every relation API funnels through, so no read path can skip silently. The three metadata-fetch tests had been rewritten to assert a tag row exists in information_schema, which also holds before the API switch and so could not catch a regression back to the macro path. Reinstate the fetch_tags override alongside the tag assertion so each test proves reads bypass the macro and the tags are correct. Also correct the pagination comment: max_results is a page size, not a cap, and the SDK generator follows next_page_token, so no 50-tag limit is relied on.
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1603 by @sd-db. Testing commit 6c201cc. Track progress in the Actions tab. |
|
Integration results for PR #1603 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success · Shard coverage ✅ success |
sd-db
marked this pull request as ready for review
August 10, 2026 05:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Table-tag metadata reads currently use
system.information_schema.table_tags, which sends each relation lookup through the more restrictive information-schema path. This changes onlytable_tagsmetadata reads to use the Unity Catalog Entity Tag Assignments API through the adapter existing authenticatedWorkspaceClient.column_tagson its existingINFORMATION_SCHEMApath; batching column assignments is outside this PR.fetch_tagsmacro as a compatibility surface for projects that invoke or override it directly.Verification
1.13.latest: 1,263 passed, 7 skippedChecklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.dbt-databricks-pr-readyproject skill for this PR and addressed its merge-readiness feedback