Skip to content

ui: show a scroll hint when a picker list is too long to fit - #298

Merged
tt-le merged 3 commits into
mainfrom
tien/picker-scroll-hint
Aug 10, 2026
Merged

ui: show a scroll hint when a picker list is too long to fit#298
tt-le merged 3 commits into
mainfrom
tien/picker-scroll-hint

Conversation

@tt-le

@tt-le tt-le commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

questionary scrolls a window over a long choice list but never says so. On the model / budget / tier pickers — a real workspace exposes ~16 GPT model ids — a user can't tell there are options below the fold.

prompt_for_selection and prompt_for_multi_selection now append ↑/↓ scroll to the instruction line once the option count passes the visible-row count (10, matching mcp.py's MCP_PICKER_VISIBLE_ROWS).

Scope

Discoverability only:

  • Scrolling already worked — this just advertises it.
  • The hint extends the instruction rather than replacing it, so a searchable long list still shows type to filter.
  • Short lists stay terse.
  • No pagination: these are fully in-memory lists with type-to-filter, so fetch-more would add complexity for no gain.

Tests

+5, mutation-verified (a no-op hint fails the long-list cases). Threshold is inclusive of 10 — exactly the visible rows still fit.

This pull request and its description were written by Isaac.

questionary scrolls a window over a long choice list but never says so, so on the
model / budget / tier pickers — a real workspace has ~16 GPT ids — a user can't
tell there are options below the fold. `prompt_for_selection` and
`prompt_for_multi_selection` now append "↑/↓ scroll" to the instruction line once
the option count passes the visible-row count (10, matching mcp.py's picker).

Discoverability only: scrolling already worked, and type-to-filter is unchanged —
the hint extends the instruction rather than replacing it, so a searchable long
list shows both. Short lists are left terse.

Tests: +5, mutation-verified — a no-op hint fails the long-list cases. Threshold
is inclusive of 10 (exactly the visible rows still fit).

Co-authored-by: Isaac
@tt-le
tt-le requested a review from AarushiShah-db August 10, 2026 15:37
@tt-le
tt-le enabled auto-merge (squash) August 10, 2026 15:58
@tt-le
tt-le merged commit 9eeeec4 into main Aug 10, 2026
2 checks passed
@tt-le
tt-le deleted the tien/picker-scroll-hint branch August 10, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants