Skip to content

[Rust] Pin rustfmt for deterministic formatting - #574

Draft
teodordelibasic-db wants to merge 1 commit into
mainfrom
teodor-delibasic_data/zerobus/rustfmt-alignment
Draft

[Rust] Pin rustfmt for deterministic formatting#574
teodordelibasic-db wants to merge 1 commit into
mainfrom
teodor-delibasic_data/zerobus/rustfmt-alignment

Conversation

@teodordelibasic-db

@teodordelibasic-db teodordelibasic-db commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

What changes are proposed in this pull request?

Rust formatting can drift between local development and CI when they use different rustfmt releases. This PR makes formatting deterministic:

  • pins formatting to nightly-2025-08-07 behind a shared .github/scripts/rustfmt.sh entry point;
  • adds repository-level rustfmt settings and routes local Makefile and CI formatting entry points through the pinned formatter;
  • applies the resulting one-time mechanical reformat to the Rust workspace and the Rust portions of the Python and TypeScript SDKs.

Compilation, linting, and tests continue to use the existing stable toolchains. The pin applies only to formatting.

How is this tested?

No behavioral tests were added because this PR changes formatting configuration and mechanically reformats existing sources. Validation focused on formatter selection, configuration discovery, and the affected entry points:

  • the shared wrapper selected nightly-2025-08-07 and reported rustfmt 1.8.0-nightly (7d82b83ed5 2025-08-06);
  • pinned formatter checks passed for the Rust workspace and the Rust portions of the Python and TypeScript SDKs;
  • effective configuration checks from the Python and TypeScript subprojects confirmed the repository-level edition, newline, import, and width settings;
  • the Go and .NET Rust formatting entry points successfully delegated to the shared wrapper;
  • a second formatting pass produced no Rust source diff;
  • the GitHub Actions formatter jobs passed for Rust, Python, Go, .NET, and the cross-SDK paths; the full matrix completed with 61 checks passed and 5 path-filtered checks skipped.

@teodordelibasic-db
teodordelibasic-db force-pushed the teodor-delibasic_data/zerobus/rustfmt-alignment branch 3 times, most recently from 0c21341 to 392dff9 Compare July 23, 2026 09:49
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
@teodordelibasic-db
teodordelibasic-db force-pushed the teodor-delibasic_data/zerobus/rustfmt-alignment branch from 392dff9 to d480aaf Compare July 23, 2026 11:40
@teodordelibasic-db teodordelibasic-db changed the title [Rust] Pin and align rustfmt with Universe [Rust] Pin rustfmt for deterministic formatting Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant