Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"summary": {
"column map generator commit SHA": "",
"data processing script commit SHA": "",
"total StatVarObservations": 3774
},
"2012": {
"filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The filename value S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv includes a placeholder timestamp 1111-11-11T111111. While this is likely for test determinism, it's an unusual value that could be confusing. Consider using a more descriptive placeholder or adding a comment in the test setup explaining its purpose.

"number of columns in dataset": 146,
"number of rows in dataset": 998,
"number of statVars generated for columns": 108,
"number of observations": 3774,
"number of unique StatVars with observations": 108,
"number of unique geos": 35,
"number of StatVars in mcf_dict": 108
}
}
Comment on lines +1 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file is missing a final newline character. It's a common convention to end text files with a newline. This helps prevent issues with file processing and tools like cat.

Suggested change
{
"summary": {
"column map generator commit SHA": "",
"data processing script commit SHA": "",
"total StatVarObservations": 3774
},
"2012": {
"filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv",
"number of columns in dataset": 146,
"number of rows in dataset": 998,
"number of statVars generated for columns": 108,
"number of observations": 3774,
"number of unique StatVars with observations": 108,
"number of unique geos": 35,
"number of StatVars in mcf_dict": 108
}
}
{
"summary": {
"column map generator commit SHA": "",
"data processing script commit SHA": "",
"total StatVarObservations": 3774
},
"2012": {
"filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv",
"number of columns in dataset": 146,
"number of rows in dataset": 998,
"number of statVars generated for columns": 108,
"number of observations": 3774,
"number of unique StatVars with observations": 108,
"number of unique geos": 35,
"number of StatVars in mcf_dict": 108
}
}

1,516 changes: 199 additions & 1,317 deletions scripts/us_census/acs5yr/subject_tables/s0902/testdata/column_map.json

Large diffs are not rendered by default.

Binary file not shown.
3,775 changes: 3,775 additions & 0 deletions scripts/us_census/acs5yr/subject_tables/s0902/testdata/test_S0902_cleaned.csv

Large diffs are not rendered by default.

Loading
Loading