Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1456.
Datasource uploads accept CSV extensions case-insensitively, but the readers and the legacy upload endpoint selected the Excel parser for stored names such as
orders.CSV. Use the same case-insensitive CSV check for preview, import, CSV sheet naming and the legacy upload endpoint. Keep the original filename and path so existing stored uploads work too.Verification
.csv,.CSVand.CsVfiles, an Excel workbook namedsales.CSV.xlsx, and a multipart request to the legacy upload route. Five failed on the base commit. All eight pass with this change./datasource/parseExcel,/datasource/importToDband/datasource/uploadExcelwith FastAPI TestClient, test identity and a disposable PostgreSQL 17.11 database. Each suffix produced the same two preview rows, the import returnedSheet1, and both import paths persisted the expected rows.2e81ded5had 66 passes and 14 failures. This branch has 71 passes and 9 failures. The remaining nine are unchanged upload guard failures: seven expect a top-levelfilePathand two expect a different rejection detail fororders.xlsx:extra.