Refactor dim_orgs and incorporate changes into sales_sync#125
Open
leoebfolsom wants to merge 6 commits intomasterfrom
Open
Refactor dim_orgs and incorporate changes into sales_sync#125leoebfolsom wants to merge 6 commits intomasterfrom
leoebfolsom wants to merge 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
View CI Job Details →
Data Diffs of tables modified in this pull request: 3
| Base branch | Pull Request branch |
| master (1504585) | update-dim_users-dim_orgs (9df55af) |
- Different: 2
- Identical: 1
Details
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | update-dim_users-dim... | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↑ 5 +25.0% | ||||||||||||
| Exclusive PKs | 0 | 1 | ||||||||||||
| View details → | ||||||||||||||
| 2 potential data app dependencies | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
| DEMO.CORE.DIM_ORGS | ||||||||||||||||
Primary keys ORG_ID |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
3 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
| 18 potential data app dependencies | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
| DEMO.CORE.DIM_USERS | ||||||||||||||||||
Primary keys USER_ID |
||||||||||||||||||
| View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables| DEMO.CORE.fct_monthly_financials (table) | Run Data Diff → |
| DEMO.CORE.fct_yearly_financials (table) | Run Data Diff → |
There was a problem hiding this comment.
View CI Job Details →
Data Diffs of tables modified in this pull request: 3
Data Diffs of downstream tables: 2
| Base branch | Pull Request branch |
| master (1504585) | update-dim_users-dim_orgs (9df55af) |
- Different: 2
- Identical: 1
Details
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | update-dim_users-dim... | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↑ 5 +25.0% | ||||||||||||
| Exclusive PKs | 0 | 1 | ||||||||||||
| View details → | ||||||||||||||
| 2 potential data app dependencies | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
| DEMO.CORE.DIM_ORGS | ||||||||||||||||
Primary keys ORG_ID |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
3 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
| 18 potential data app dependencies | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
| DEMO.CORE.DIM_USERS | ||||||||||||||||||
Primary keys USER_ID |
||||||||||||||||||
| View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
- Different: 2
Details
| DEMO.CORE.FCT_MONTHLY_FINANCIALS | ||||||||||||||||
Primary keys DATE_MONTH |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
1 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
| 4 potential data app dependencies | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
Modified upstream modelsmodel.demo.dim_orgs |
||||||||||||||||
| DEMO.CORE.FCT_YEARLY_FINANCIALS | ||||||||||||||||
Primary keys DATE_YEAR |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
1 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
Modified upstream modelsmodel.demo.dim_orgs |
||||||||||||||||
There was a problem hiding this comment.
View CI Run Details →
Data Diffs of tables modified in this pull request: 3
| Base branch | Pull Request branch |
| master (1504585) | update-dim_users-dim_orgs (9df55af) |
- Different: 2
- Identical: 1
Details
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | update-dim_users-dim... | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↓ 3 -25.0% | ||||||||||||
| Exclusive PKs | 2 | 1 | ||||||||||||
| View details → | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
| DEMO.CORE.DIM_ORGS | ||||||||||||
Primary keys ORG_ID |
||||||||||||
| master | update-dim_users-dim... | |||||||||||
| DIFFERENCES | ||||||||||||
| Total rows | 157 | ↓ 146 -7.0% | ||||||||||
| Exclusive PKs | 11 | 0 | ||||||||||
2 column(s) with differing values
|
||||||||||||
| View details → | ||||||||||||
| 11 potential data app dependencies | ||||||||||||
Unchanged Attributes
|
||||||||||||
| DEMO.CORE.DIM_USERS | ||||||||||||||||||
Primary keys USER_ID |
||||||||||||||||||
| View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables| DEMO.CORE.fct_monthly_financials (table) | Run Data Diff → |
| DEMO.CORE.fct_yearly_financials (table) | Run Data Diff → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dim_orgs.created_atdim_orgsmodel is built around the first usersign_upevent, but I noticed we have anorg_createdevent that might make more sense to use.sign_upevents fororg_createdevents in modeldim_orgsdim_orgs.sub_priceto0when the value would benull.dim_orgs.sub_plantoIndividualwhennum_usersis1Individualopportunities in the Sales Sync.num_users.